[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [wakaama-dev] [mentor poking] PR request process on GH
|
Really cc'ing emo@ this time, oops.
Le 24/07/2014 11:12, « Benjamin Cabé » <benjamin@xxxxxxxxxxx> a écrit :
>Hi Julien and David,
>
>IIRC, and EMO will correct me if I'm wrong, the reason we ask every
>contributor to "Sign-off-by" is to make sure that they fully understand
>they are actually contributing code to Eclipse, and confirm that they
>have
>the rights to do so, on a per-contribution basis.
>Regarding the github hook that seems to be broken, hopefully webmaster
>will look into it soon.
>
>> Also do the committer merging the PR need to also sign-off the commit
>> with his own email for claiming he made the CLA verification?
>
>
>I leave it to EMO to answer the question, I don't know the answer
>unfortunately.
>
>Thanks for reaching out!
>Benjamin
>
>
>Le 24/07/2014 10:38, « Julien Vermillard » <jvermillard@xxxxxxxxx> a
>écrit
>:
>
>>Hi,
>>We started looking at the PR merging process with David, and it's not
>>really clear :(
>>
>>First we understood that a PR should be done by someone with a CLA,
>>this one was easy, except the advertised github hook verification (see
>>https://bugs.eclipse.org/bugs/show_bug.cgi?id=440194 )
>>
>>Anyway checking using the CLA validation tool is quite easy :)
>>
>>The signoff stuff is really obscure to me, if I follow this doc:
>>https://wiki.eclipse.org/Development_Resources/Handling_Git_Contributions
>>
>>The contribution authors need to add a Signed-off-by with his email
>>address even if his email address is already in the commit as author?
>>
>>Also do the commiter merging the PR need to also sign-off the commit
>>with his own email for claiming he made the CLA verification?
>>--
>>Julien Vermillard :::: http://people.apache.org/~jvermillard/
