Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[wakaama-dev] [mentor poking] PR request process on GH

Hi,
We started looking at the PR merging process with David, and it's not
really clear :(

First we understood that a PR should be done by someone with a CLA,
this one was easy, except the advertised github hook verification (see
https://bugs.eclipse.org/bugs/show_bug.cgi?id=440194 )

Anyway checking using the CLA validation tool is quite easy :)

The signoff stuff is really obscure to me, if I follow this doc:
https://wiki.eclipse.org/Development_Resources/Handling_Git_Contributions

The contribution authors need to add a Signed-off-by with his email
address even if his email address is already in the commit as author?

Also do the commiter merging the PR need to also sign-off the commit
with his own email for claiming he made the CLA verification?
--
Julien Vermillard :::: http://people.apache.org/~jvermillard/


Back to the top