[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [virgo-dev] Virgo Tools and Server Editor

Hi GianMaria,

> Sorry to bother you, everything is still very new to me.

No worries. Please keep the ideas flowing in.

> As suggested by Florian, I'll reformat the IDE plug-ins code base to comply with the formatting and clean-up rules of the server code.
> Should this be tracked by a bugzilla entry?

+1 for creating bugzilla https://bugs.eclipse.org/bugs/show_bug.cgi?id=478976

> I have another question, about code review. In my team we apply peer review and a feature branch cannot be merged into master without a review. 
> Is this practice in place here or is it suspended due to lack of resources?

In general I like code reviews. Personally I can not promise to review code changes carefully and as quickly as I would like. So I wouldnât enforce this policy
currently for Virgo. On the other hand please do not hesitate to ask actively for reviews if you think a second opinion is useful.