Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [udig-dev] 1.5.0 Problem with Layers View 
I created a pull request:
https://github.com/uDig/udig-platform/pull/187
In reviewing the emf model changes, I saw some other changes that could potentially cause problems. I don't know but if we come across other event type bugs we should remember that this may be the cause of the issue. 

I do think this greatly impacts users who want to view more than one map.

Emily



On 12/02/2015 11:38 AM, Jody Garnett wrote:

Excellent! If you feel this consider ability impacts usability I can
make an RC2 tomorrow (and just update the blog post in place).
--
Jody

--
Jody Garnett

On 12 February 2015 at 13:39, Emily Gouge <egouge@xxxxxxxxxxxxxxx
<mailto:egouge@xxxxxxxxxxxxxxx>> wrote:

    Yes it does look like a EMF model change issue.  When regenerated,
    ProjectItemProviderAdapterFact__ory class now reuses providers
    instead of generating new ones.  If we generate new ones it seems to
    resolve my immediate issue.
    The initial changes can been seen in this commit:
    https://github.com/uDig/udig-__platform/commit/__31fd6f2efdbd6cbf5768bb8d78b65c__472b0534e4
    <https://github.com/uDig/udig-platform/commit/31fd6f2efdbd6cbf5768bb8d78b65c472b0534e4>

    I will try to come up with a patch.

    Thanks Jody,
    Emily


    On 12/02/2015 10:04 AM, Jody Garnett wrote:

        Well that is kind of good news (that the issue is not due to the
        migration to luna).

        My thought is that either the EMF model changed, or that the EMF
        model
        was used to re-generate / update the code in place. Since we
        subclass or
        override a few of our models care/QA is always needed when
        performing
        this step.

        As a last ditch effort you can use git-bisect to determine when this
        issue was introduced. If we can identify the commit we can have some
        context for this discussion.

        It is likely that changes were being made to the EMF model to
        assist the
        canceled LISAsoft project. If that is the case we can review the
        changes
        and revert if necessary.

        --
        Jody Garnett

        On 12 February 2015 at 12:29, Emily Gouge
        <egouge@xxxxxxxxxxxxxxx <mailto:egouge@xxxxxxxxxxxxxxx>
        <mailto:egouge@xxxxxxxxxxxxxxx
        <mailto:egouge@xxxxxxxxxxxxxxx>__>> wrote:

             I have a problem with the layers views not refreshing
        properly with
             multiple maps.  Initially I found this issue on the
        luna-branch, but
             I tested the 1.5.0 release and it also exists there.

             The problem arises only when more than one map is open.  To
        reproduce:
             1) Open a map & add a shapefile layer to this map
             2) Open a second map
             3) Add a shapefile layer to the second map
             At this point the layers view will add the layer, but it
        will not be
             checked.
             4) Add a second shapefile layer (to the second map).  Now, the
             layers view does not even display the new layer.

             The map is updated fine, this is just a problem with the
        layers view
             not being refreshed in modifying layers.  If you switch
        between maps
             the layers view is refreshed properly.  The problem also
        exists if
             you try to delete a layer from the second map (it gets
        deleted from
             the map but not the layers view).  I tracked this down to some
             events are not being fired when the second map is active;
        but where
             the events originate I have not found yet.

             Does anyone have any thoughts on what might have changed?
        This was
             not a problem for in previous versions (1.4.0).

             Thanks,
             Emily

             ___________________________________________________
             udig-dev mailing list
        udig-dev@xxxxxxxxxxxxxxxx <mailto:udig-dev@xxxxxxxxxxxxxxxx>
        <mailto:udig-dev@locationtech.__org
        <mailto:udig-dev@xxxxxxxxxxxxxxxx>>
             To change your delivery options, retrieve your password, or
             unsubscribe from this list, visit
        https://locationtech.org/____mailman/listinfo/udig-dev
        <https://locationtech.org/__mailman/listinfo/udig-dev>
             <https://locationtech.org/__mailman/listinfo/udig-dev
        <https://locationtech.org/mailman/listinfo/udig-dev>>




        _________________________________________________
        udig-dev mailing list
        udig-dev@xxxxxxxxxxxxxxxx <mailto:udig-dev@xxxxxxxxxxxxxxxx>
        To change your delivery options, retrieve your password, or
        unsubscribe from this list, visit
        https://locationtech.org/__mailman/listinfo/udig-dev
        <https://locationtech.org/mailman/listinfo/udig-dev>

    _________________________________________________
    udig-dev mailing list
    udig-dev@xxxxxxxxxxxxxxxx <mailto:udig-dev@xxxxxxxxxxxxxxxx>
    To change your delivery options, retrieve your password, or
    unsubscribe from this list, visit
    https://locationtech.org/__mailman/listinfo/udig-dev
    <https://locationtech.org/mailman/listinfo/udig-dev>




_______________________________________________
udig-dev mailing list
udig-dev@xxxxxxxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://locationtech.org/mailman/listinfo/udig-dev

Back to the top