Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [udig-devel] double loading of tiffs (geotiff + world file)

Ok, thanks, at least then there will be someone to blame!

Cheers,
Andrea



On Tue, Mar 8, 2011 at 1:25 PM, Jesse Eichar
<jesse.eichar@xxxxxxxxxxxxxx> wrote:
> clean it! (and thanks)
>
> On Tue, Mar 8, 2011 at 12:36 PM, andrea antonello
> <andrea.antonello@xxxxxxxxx> wrote:
>>
>> Alright, while solving a couple of issues in the profile tool I gave a
>> better look at the tiff handling services.
>> The funny thing is that in the WorldImageGeoResourceImpl.java there is
>> a dirty hack that should probably push it to not resolve tiffs:
>>
>>    public <T> boolean canResolve( Class<T> adaptee ) {
>>        if (GridCoverageLoader.class.isAssignableFrom(adaptee) &&
>> !isTiff())
>>            return true;
>>
>>        return super.canResolve(adaptee);
>>    }
>>
>> (note the !isTiff())
>>
>> This doesn't make much sense to me, since here the service is already
>> chosen and it should resolve in a Gridcoverage.
>> I would appreciate a comment from the author here, else I would be
>> tempted to remove that method.
>>
>> As it seems there has been a lot of hacks to make choices between
>> tiffs and worldimage tiffs and I guess it is due to not wanting to
>> read the formats with their proper readers. The mess is not worth the
>> game in my opinion. If I get no counterorders, I will start cleaning
>> up such things.
>>
>> Again, if one wants to force a tiff to be read by the geotiff reader,
>> he should remove the tfw and see if it is able to read it. Forcing a
>> missbehaviour in the catalog system is not the solution.
>>
>> My 2c,
>> Andrea
>>
>>
>>
>>
>>
>> On Tue, Mar 8, 2011 at 9:14 AM, andrea antonello
>> <andrea.antonello@xxxxxxxxx> wrote:
>> > The problem of the subject has been discussed a couple of times and
>> > never felt as a real problem by the PSC at least.
>> > For those who work with many tiffs, this is a showstopper. Imagine
>> > loading 20 tiffs and finding yourself with 40 loaded. A complete mess.
>> > Therefore I took the chance and made a fix forcing the geotiff service
>> > extension to check if the loaded tiff is not instead an
>> > image+worldfile.
>> >
>> > The fix works, there might still be doubts. There is a discussion
>> > ongoing in my pull request, to which I would like to drive your
>> > attention, to hear some feedback. i would be keen to do the merge and
>> > see how that evolves. Read here please:
>> > https://github.com/uDig/udig-platform/pull/9
>> >
>> > Comments welcome,
>> > Andrea
>> >
>> _______________________________________________
>> User-friendly Desktop Internet GIS (uDig)
>> http://udig.refractions.net
>> http://lists.refractions.net/mailman/listinfo/udig-devel
>
>


Back to the top