[udig-devel] Re: [Geotools-devel] Filter to be immutable?

[Justin Deoliveira <jdeolive@xxxxxxxxxxxxx>]

+1.

If you make the changes I will review. Then we hunt down where any 
setters on the interfaces are being used and replace them with factory 
methods. Should be pretty painless.

-Justin

Jody Garnett wrote:
> Guys I *really* want to make filter and expression immutable - but I 
> need your help (ie vast agreement and a "mandate" to go fix the GeoAPI 
> interfaces before we start using them in anger).
>
> Any suggestions on how to proceed without annoying others would be 
> great; the coding thing is easy on this one.
>
> Cheers,
> Jody
>
> Andrea Aime wrote:
> > They should be immutable IMHO... but the even the filter interfaces do 
> > allow for modification after the filter is built, and nothing is stated
> > in the javadoc.
> > In a perfect world filters should take their arguments during
> > construction and then be immbutable. Maybe in gt2 2.4 things are better,
> > how's the situation with the new Filter interfaces?
> >
> > Cheers
> > Andrea
> > _______________________________________________
> > User-friendly Desktop Internet GIS (uDig)
> > http://udig.refractions.net
> > http://lists.refractions.net/mailman/listinfo/udig-devel
>
>
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys - and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> _______________________________________________
> Geotools-devel mailing list
> Geotools-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>
> !DSPAM:1004,456dd49e318421510810322!


--
Justin Deoliveira
jdeolive@xxxxxxxxxxxxx
The Open Planning Project
http://topp.openplans.org