Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [tycho-user] Single plugin is not being signed during the build

It’s Ant glob pattern: https://maven.apache.org/plugins/maven-jarsigner-plugin/sign-mojo.html#includes

 

I would expect Ant patterns in all Maven plugins, and never use regex, unless some documentation explicitly mentions to support regular expressions.

 

Mit freundlichen Grüßen / Best regards

Michael Keppler

LTO Release Engineering (ETAS/ESW-CI)
Tel. +49 711 3423-2429 | Fax +49 711 89661-0 | Michael.Keppler@xxxxxxxx



Von: tycho-user <tycho-user-bounces@xxxxxxxxxxx> Im Auftrag von Ed Merks
Gesendet: Dienstag, 2. März 2021 10:19
An: tycho-user@xxxxxxxxxxx
Betreff: Re: [tycho-user] Single plugin is not being signed during the build

 

Alex,

I wonder what kind of "pattern" syntax is supported here.  I.e., is this a regular _expression_ where '.*' matches zero or more characters, or does the '.' match a '.' and the '*' matches zero or more characters?  I ask because the one failure is for  'yedit_' suggesting that the '.' must literally match a '.' and that it does not match the '_'.

Regards,
Ed

 

On 01.03.2021 15:58, Alex Kravets wrote:

Hello,

 

During building of p2 repository I am signing jars with maven-jarsigner-plugin

 

<plugin>
  <groupId>org.apache.maven.plugins</groupId>
  <artifactId>maven-jarsigner-plugin</artifactId>
  <version>1.2</version>
  <configuration>
    <keystore>${keystore.path}</keystore>
    <verbose>true</verbose>
    <alias>${keystore.alias}</alias>
    <storepass>${keystore.store.password}</storepass>
    <storetype>${keystore.type}</storetype>
    <arguments>
      <argument>-tsa</argument>
      <argument>${keystore.timestamp.url}</argument>
      <argument>-digestalg</argument>
      <argument>${keystore.digestalg}</argument>
      <argument>-sigalg</argument>
      <argument>${keystore.sigalg}</argument>
    </arguments>
    <archiveDirectory>${project.build.directory}/repository</archiveDirectory>
    <includes>
      <include>features/com.iwaysoftware.*.jar</include>
      <include>plugins/com.iwaysoftware.*.jar</include>

      <include>plugins/org.eclipse.nebula.*.jar</include>

      <include>features/org.dadacoalition.yedit.*.jar</include>
      <include>plugins/org.dadacoalition.yedit.*.jar</include>
    </includes>
  </configuration>
  <executions>
    <execution>
      <id>sign</id>
      <phase>package</phase>
      <goals>
        <goal>sign</goal>
      </goals>
    </execution>
  </executions>
</plugin>

Signing works for all plugins and features except one - org.dadacoalition.yedit_1.0.20.201509041456-RELEASE.jar. In the log I see both the plugin and its feature being signed, but in the final p2 repository only feature is signed and has all necessary files in META-INF:

[INFO] --- maven-jarsigner-plugin:1.2:sign (sign) @ iWayIntegrationTools ---
[INFO] Processing /home/akravets/git/805-release/iiteclipse/com.iwaysoftware.integration.tools.repository.feature/target/iWayIntegrationTools-8.0.5-SNAPSHOT.zip
[INFO]    adding: META-INF/MANIFEST.MF
[INFO]    adding: META-INF/TE-6AC98.SF
[INFO] requesting a signature timestamp
[INFO] TSA location: http://timestamp.digicert.com
[INFO]    adding: META-INF/TE-6AC98.RSA
[INFO]    adding: features/
[INFO]    adding: plugins/
[INFO]    adding: binary/
[INFO]   signing: artifacts.jar
[INFO]   signing: artifacts.xml.xz
[INFO]   signing: content.xml.xz
[INFO]   signing: features/com.iwaysoftware.eclipse.template.feature_8.0.5.R20210227-1629.jar
[INFO]   signing: features/com.iwaysoftware.eclipse.iia.feature_8.0.5.R20210227-1629.jar
[INFO]   signing: features/com.iwaysoftware.integration.tools.feature_8.0.5.R20210227-1629.jar
[INFO]   signing: features/com.iwaysoftware.core.services.base.feature_8.0.5.R20210227-1629.jar
[INFO]   signing: features/com.iwaysoftware.tools.feature_8.0.5.R20210227-1629.jar
[INFO]   signing: features/com.iwaysoftware.transformer.feature_8.0.5.R20210227-1629.jar
[INFO]   signing: features/com.iwaysoftware.common.feature_8.0.5.R20210224-1729.jar
[INFO]   signing: features/com.iwaysoftware.explorer.feature_8.0.5.R20210227-1629.jar
[INFO]   signing: features/com.iwaysoftware.configuration.feature_8.0.5.R20210227-1629.jar
[INFO]   signing: features/com.iwaysoftware.designer.diagram.feature_8.0.5.R20210227-1629.jar
[INFO]   signing: features/org.dadacoalition.yedit.feature_1.0.20.201509041456-RELEASE.jar
[INFO]   signing: features/com.iwaysoftware.ebix.feature_8.0.5.R20210227-1629.jar
[INFO]   signing: features/com.iwaysoftware.integration.tools.product.feature_8.0.5.R20210227-1629.jar
[INFO]   signing: features/com.iwaysoftware.i18n.fragments.feature_8.0.5.R20210227-1629.jar
[INFO]   signing: features/com.iwaysoftware.eclipse.api.feature_8.0.5.R20210227-1629.jar
[INFO]   signing: features/com.iwaysoftware.eclipse.json.feature_8.0.5.R20210227-1629.jar
[INFO]   signing: features/com.iwaysoftware.channel.feature_8.0.5.R20210227-1629.jar
[INFO]   signing: features/com.iwaysoftware.eclipse.server.feature_8.0.5.R20210226-0339.jar
[INFO]   signing: features/com.iwaysoftware.eclipse.iit.trial.feature_8.0.5.R20210227-1629.jar
[INFO]   signing: features/org.eclipse.m2e.feature_1.7.0.20160603-1933.jar
[INFO]   signing: plugins/com.iwaysoftware.eclipse.config.editor_8.0.5.R20210227-1629.jar
[INFO]   signing: plugins/org.eclipse.m2e.profiles.core_1.7.0.20160603-1933.jar
[INFO]   signing: plugins/org.eclipse.m2e.refactoring_1.7.0.20160603-1933.jar
[INFO]   signing: plugins/com.iwaysoftware.core.services_8.0.5.R20210224-1729.jar
[INFO]   signing: plugins/org.eclipse.nebula.widgets.datechooser_1.0.0.R20210227-1629.jar
[INFO]   signing: plugins/com.iwaysoftware.eclipse.common_8.0.5.R20210224-1729.jar
[INFO]   signing: plugins/org.eclipse.m2e.model.edit_1.7.0.20160603-1933.jar
[INFO]   signing: plugins/com.iwaysoftware.simple.xml_8.0.5.R20210224-1729.jar
[INFO]   signing: plugins/com.iwaysoftware.eclipse.workspace_8.0.5.R20210224-1729.jar
[INFO]   signing: plugins/com.iwaysoftware.eclipse.channel.core_8.0.5.R20210227-1629.jar
[INFO]   signing: plugins/com.iwaysoftware.iwtrans.editor_8.0.5.R20210227-1629.jar
[INFO]   signing: plugins/com.iwaysoftware.integration.ant_8.0.5.R20210227-1629.jar
[INFO]   signing: plugins/com.iwaysoftware.eclipse.jsonpath.builder_8.0.5.R20210227-1629.jar
[INFO]   signing: plugins/org.eclipse.m2e.workspace.cli_0.3.1.jar
[INFO]   signing: plugins/com.iwaysoftware.eclipse.channel.ui_8.0.5.R20210227-1629.jar
[INFO]   signing: plugins/com.iwaysoftware.eclipse.config_8.0.5.R20210227-1629.jar
[INFO]   signing: plugins/com.iwaysoftware.irexp_8.0.5.R20210227-1629.jar
[INFO]   signing: plugins/com.iwaysoftware.integration.deployment_8.0.5.R20210227-1629.jar
[INFO]   signing: plugins/com.iwaysoftware.eclipse.api_8.0.5.R20210227-1629.jar
[INFO]   signing: plugins/com.iwaysoftware.library.ui_8.0.5.R20210227-1629.jar
[INFO]   signing: plugins/com.iwaysoftware.iwresource.model.emf.edit_8.0.5.R20210224-1729.jar
[INFO]   signing: plugins/com.iwaysoftware.eclipse.birt.runtime_8.0.5.R20210224-1729.jar
[INFO]   signing: plugins/jsonedit-editor_1.1.1.jar
[INFO]   signing: plugins/com.iwaysoftware.ieexp_8.0.5.R20210227-1629.jar
[INFO]   signing: plugins/com.iwaysoftware.iamp_8.0.5.R20210227-1629.jar
[INFO]   signing: plugins/org.dadacoalition.yedit_1.0.20.201509041456-RELEASE.jar

 

yedit-plugin.png

yedit-feature.png

Can some suggest why might happen and how to resolve it?

 

Regards,

Alex



_______________________________________________
tycho-user mailing list
tycho-user@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/tycho-user

Back to the top