thanks Marcel for reporting back.
This is actually a FAQ and you might consider posting your findings to stackoverflow or tycho wiki [1].
Also see previous stackoverflow answer by Andrew Niefer [2].
Regarding the implementation, Tycho delegates this completely to the p2 product publisher/director so in case there is a bug,
you would have to report it for p2.
Regards,
Jan
[1]
https://wiki.eclipse.org/Tycho/FAQ
[2]
http://stackoverflow.com/questions/10999323/error-in-tycho-while-replacing-the-product-ico-files
From: tycho-user-bounces@xxxxxxxxxxx [mailto:tycho-user-bounces@xxxxxxxxxxx]
On Behalf Of David M Williams
Sent: Donnerstag, 1. Mai 2014 17:18
To: Tycho user list
Subject: Re: [tycho-user] "Error - 1 icon(s) not replaced", missing 256x256x32 bitmap
Glad you got it going.
Sounds like original issue is a legitimate bug, though. And, sounds like you got into it pretty deep, so would be good if you opened it with your findings.
(But, I know, to go ahead and say what I know Tycho committers would say "You must provide a small example that demonstrate the problem" ... it is not always easy to provide a small example ...
but IMHO, even if you don't have time to do that, still good to have a bug open, with the work-around ... and if you can't, perhaps someone else can create a small example demonstrating the problem some day).
Thanks for letting us know.
From: Marcel Romijn <mromijn@xxxxxxxxxxxxxxxxxx>
To: Tycho user list <tycho-user@xxxxxxxxxxx>,
Date: 05/01/2014 11:02 AM
Subject: Re: [tycho-user] "Error - 1 icon(s) not replaced", missing 256x256x32 bitmap
Sent by: tycho-user-bounces@xxxxxxxxxxx
Hi David,
The application we use to create ICO files, has by default the ‘compress’ checkbox checked for 256x256x32 bitmaps. And indeed, the original ICO file has the 256x256x32 bitmap compressed.
We created a new ICO file, based on the 7 (uncompressed) BMPs and made sure that the resulting ICO still has all entries uncompressed.
When we use that ICO file for the product build, all 7 bitmaps in the native launcher are replaced!
Thanks for the advice!
Marcel
From: tycho-user-bounces@xxxxxxxxxxx [mailto:tycho-user-bounces@xxxxxxxxxxx]
On Behalf Of Marcel Romijn
Sent: Thursday, May 01, 2014 16:08 PM
To: Tycho user list
Subject: Re: [tycho-user] "Error - 1 icon(s) not replaced", missing 256x256x32 bitmap
Hi David,
The 256x256 image is uncompressed.
However the problem does not seem to be that Tycho can’t read it, but that the
tycho-p2-publisher-plugin plugin is not aware of its existence when it prepares the target.
But you make a good point… We have an ICO file from which I extracted the BMPs. I extracted those because when I used the ICO file, the
tycho-p2-publisher-plugin plugin also could not replace 1 icon.
But if the 256x256 BMP inside the ICO is compressed, then that might have been the cause…!
So I will take the 7 (uncompressed) BMPs and create an ICO out of it.
I’ll report back…
Marcel
From:
tycho-user-bounces@xxxxxxxxxxx [mailto:tycho-user-bounces@xxxxxxxxxxx]
On Behalf Of David M Williams
Sent: Thursday, May 01, 2014 15:48 PM
To: Tycho user list
Subject: Re: [tycho-user] "Error - 1 icon(s) not replaced", missing 256x256x32 bitmap
Is your 256x256 image compressed? I've heard a rumor that Tycho can't use/read a "compressed" large image, but if you leave it un-compressed it should work [1] but I have no personal experience
with this -- and there are other parts of that reference that are out of date, so as far as i know it all is.
[1] http://andrius.velykis.lt/2012/10/creating-icons-for-eclipse-rcp-launcher/
If all else fails, you could make the ICO file "ahead of time" and use it directly. My personal experience it that it will be used (replacing existing ico resource in executable).
HTH
From: Marcel Romijn <mromijn@xxxxxxxxxxxxxxxxxx>
To: Tycho user list <tycho-user@xxxxxxxxxxx>,
Date: 05/01/2014 08:45 AM
Subject: [tycho-user] "Error - 1 icon(s) not replaced", missing 256x256x32 bitmap
Sent by: tycho-user-bounces@xxxxxxxxxxx
Hi all,
While trying to materialize a .product with Tycho, we cannot replace all bitmaps in the native launcher.
We are using Windows and Tycho 0.20.0.
The launcher.exe has 7 bitmaps that need to be replaced. These bitmaps are specified in the
.product file.
During the build, we get the following error:
Error - 1 icon(s) not replaced in […]\launcher.exe using […]
The resulting native launcher has 6 of its 7 bitmaps replaced. The bitmap that is not replaced is the largest one of size 256x256 and depth 32.
The location of the .product file contains all 7 bitmaps, but when I look at the target folder:
target\products\<prodId> I only see 6 bitmaps and it is missing the largest one.
So, 7 bitmaps are defined in the .product file, 7 bitmaps are available, but only 6 of them are copied to the target folder to be used in the materialized
product.
I found this bug [1] where something similar should be solved. But according to comment 7, Andy Jin reported that it still happens with Tycho 0.19.0.
Tobias Oberlies reports in comment 8 that a fix was made in eclipse-application, not in
eclipse-repository. But when I run the Tycho build with
eclipse-application, I get a remark that it is deprecated and should use
eclipse-repository and instead of 1 icon not replaced, it now mentions that 7 icons are not replaced.
I looked at the source of PublishProductMojo in
tycho-p2-publisher-plugin and finally ended up at
org.eclipse.tycho.model.Launcher.
This class gathers the paths for the bitmaps, as specified in the .product file. However, it is only aware of 6 bitmaps. It is not aware of the 7th
large bitmap (stored in attribute “winExtraLargeHigh”)
How should this be fixed?
[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=384509
Marcel Romijn
Software Engineer
Rocket Software
Korte Parallelweg 1 • 3311 JN Dordrecht • Netherlands
Tel: +31 78 6322800 • Fax: +31 78 6138134
Email: mromijn@xxxxxxxxxxxxxxxxxx
Web: seagull.rocketsoftware.com
Twitter
• Facebook
• YouTube •
LinkedIn
_______________________________________________
tycho-user mailing list
tycho-user@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/tycho-user_______________________________________________
tycho-user mailing list
tycho-user@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/tycho-user
