Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [tycho-user] Tycho build fails when putting org.eclipse.ui.internal.decorators dependency in manifest

If org.eclipse.ui.internal.decorators  a bundle or a package dependency.
If this is a package, then it is probably also implemented by RAP and RAP is also know to implement SWT.
You should not import *internal* packages or you should fine tune your import to make sure the correct bundle is imported (the one that does not come from RAP.

Jeff


On Mon, Jul 22, 2013 at 2:31 PM, Velde, Erik Vande [FGCB] <EvandeVelde@xxxxxxxx> wrote:

Thanks for the information Jeff. I know that the RAP bundles give trouble, but why does tycho replace the SWT bundles by the RAP ones as soon as I include the org.eclipse.ui.internal.decorators dependency?

 

Kind regards,
Fugro GeoConsulting

Erik Vande Velde
Senior Software Coordinator

Telephone: +32 (0)2 77 60 034 / Fax: +32 (0)2 77 60 319
E-mail: EvandeVelde@xxxxxxxx / Website: www.fugro.be
Address: Av. de Broqueville 12, 1150 Brussels, Belgium
VAT Nr: BE0418609636

From: tycho-user-bounces@xxxxxxxxxxx [mailto:tycho-user-bounces@xxxxxxxxxxx] On Behalf Of Jeff MAURY
Sent: 22 July 2013 13:01
To: Tycho user list
Subject: Re: [tycho-user] Tycho build fails when putting org.eclipse.ui.internal.decorators dependency in manifest

 

I think the difference in the presence of not of RAP bundles. In the first, no RAP bundles but SWT _ones_ ==> OK

I the second, RAP bundles but no SWT _ones_ ==> KO

 

Jeff

 

On Mon, Jul 22, 2013 at 12:37 PM, Velde, Erik Vande [FGCB] <EvandeVelde@xxxxxxxx> wrote:

Hello,

 

Last week our automatic tycho builds started failing with weird messages like the following:

 

[ERROR] C:\gwf\projects\svn\com.fugro.gwf\trunk\client_group\client\com.fugro.gwf.client.query\src\com\fugro\gwf\client\query\contentAssist\PathEditingSupport.java:[28,0]

[ERROR] KeyStroke keyStroke = KeyStroke.getInstance(SWT.CTRL, SWT.SPACE);

[ERROR] ^^^^^

[ERROR] SPACE cannot be resolved or is not a field

 

[ERROR] C:\gwf\projects\svn\com.fugro.gwf\trunk\client_group\client\com.fugro.gwf.client.query\src\com\fugro\gwf\client\query\ui\QueryBuilderUIParts.java:[19,0]

[ERROR] import org.eclipse.jface.window.ToolTip;

 

After some further analysis it became clear that a  (unused!) org.eclipse.ui.internal.decorators dependency in our manifest was the culprit.

Somehow the dependency tree of the plugin is completely different when you add this dependency, and tycho doesn’t find some core swt and jface classes any more.

The attached files show the maven dependency tree with and without this dependency.

With the dependency there are many RAP related jars, and these important dependencies are missing:

p2.eclipse-plugin:org.eclipse.swt.win32.win32.x86_64:jar:3.102.0.v20130605-1544:system

p2.eclipse-plugin:org.eclipse.swt.win32.win32.x86:jar:3.102.0.v20130605-1544:system  

 p2.eclipse-plugin:org.eclipse.jface:jar:3.9.0.v20130521-1714:system

 

The key question is: why does the org.eclipse.ui.internal.decorators dependency break our build ??

 

Kind regards,
Fugro GeoConsulting

Erik Vande Velde
Senior Software Coordinator

Telephone: +32 (0)2 77 60 034 / Fax: +32 (0)2 77 60 319
E-mail: EvandeVelde@xxxxxxxx / Website: www.fugro.be
Address: Av. de Broqueville 12, 1150 Brussels, Belgium
VAT Nr: BE0418609636


_______________________________________________
tycho-user mailing list
tycho-user@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/tycho-user



 

--
Jeff MAURY

Image removed by sender.


"Legacy code" often differs from its suggested alternative by actually working and scaling.
 - Bjarne Stroustrup

http://www.jeffmaury.com
http://riadiscuss.jeffmaury.com
http://www.twitter.com/jeffmaury


_______________________________________________
tycho-user mailing list
tycho-user@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/tycho-user




--
Jeff MAURY


"Legacy code" often differs from its suggested alternative by actually working and scaling.
 - Bjarne Stroustrup

http://www.jeffmaury.com
http://riadiscuss.jeffmaury.com
http://www.twitter.com/jeffmaury

Back to the top