Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [tycho-dev] Formater profile used in Tycho
  • From: "Sievers, Jan" <jan.sievers@xxxxxxx>
  • Date: Wed, 30 Oct 2019 16:08:33 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=sap.com; dmarc=pass action=none header.from=sap.com; dkim=pass header.d=sap.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=USwNdFCjC1zlGyDUYY+zPq22i6u0jOZLwVqhicW1KwE=; b=Y5U0RZfZJPpsEThPj5y79fZ1WJuTJFkFd8gNnuutjwlykLF/GzmmG0vl/DtppMKLW5xCAvJY9phZv2w10MpY+pdJW6GE/Qjhm5dEY+s9NnNKTETbv6ZQSCbaodIfDMZBmaHAPHqUjG7CbBk92hb5p0MxxRNS8OZVqmUYZZH/++fsOIjeR1LeIHS3ko4bw6q9VVPxUfIYHRkVGjY4lGm69SH7NoI5AMQZpi+anmiTbBRJ0F5pgj8ZEL4q9fe80jxvHTJk7hqV+6fXr9rLatvJPbZiRCNyi/E6dcsSEVcwBMkOAGmTLBy7w/x/MN2a76plMqwWvsPP191n6SOEIgyEKg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cAAlngEd/E+SRnwhrGMW1vLer7pliXebDtWxTSIF6CbWXQ4Ji4WiEw4VgPhFMUgOt8ZcyImB78e27qE3DYT1UnhPcsE9ywkCupPgy3G+c9dlC9rAlfQgzXv4p6ckTbJ2jAdfvwpJXmdcure6BZ8NVb9pD9nEfmK4OxQEYjFxe3RWT4Hrobtq8XZfPZ6vWZxdLYJLxz9wBfTq5+/n4qe52YUnI+dx8rCYu2bLDENtBr7HCaMS6WYRrf/lYgMl3HDFHmhFjrqd7bLwdk2MrRkVlQ3DzNLJkT1YaEI0NuCay/x44GzLMt/R1qkB2W5o9+mVzb/7JZ0iMqeTL3qmT0TaBA==
  • Delivered-to: tycho-dev@xxxxxxxxxxx
  • List-archive: <https://www.eclipse.org/mailman/private/tycho-dev>
  • List-help: <mailto:tycho-dev-request@eclipse.org?subject=help>
  • List-subscribe: <https://www.eclipse.org/mailman/listinfo/tycho-dev>, <mailto:tycho-dev-request@eclipse.org?subject=subscribe>
  • List-unsubscribe: <https://www.eclipse.org/mailman/options/tycho-dev>, <mailto:tycho-dev-request@eclipse.org?subject=unsubscribe>
  • Thread-index: AQHVjkPiUpYAirI57E6RXr3PrYt7RadxbycAgAAhQACAAdx6gA==
  • Thread-topic: [tycho-dev] Formater profile used in Tycho
  • User-agent: Microsoft-MacOutlook/10.1e.0.191013

AFAIK each project should have formatter prefs checked in

settings/org.eclipse.jdt.core.prefs

and they should be consistent across all tycho projects, at least that's the idea.
No opinion on which rules are used as long as they are applied consistently and as automatically as possible.

Regards,
Jan

From: <tycho-dev-bounces@xxxxxxxxxxx> on behalf of Aleksandar Kurtakov <akurtako@xxxxxxxxxx>
Reply to: Tycho list <tycho-dev@xxxxxxxxxxx>
Date: Tuesday, 29. October 2019 at 13:45
To: Tycho list <tycho-dev@xxxxxxxxxxx>
Subject: Re: [tycho-dev] Formater profile used in Tycho



On Tue, Oct 29, 2019 at 12:44 PM Mickael Istria <mailto:mistria@xxxxxxxxxx> wrote:


On Tue, Oct 29, 2019 at 11:29 AM Christoph Läubrich <mailto:laeubi@xxxxxxxxxxxxxx> wrote:
- is there any preffered profile and where do I find it?

No, there is no profile.

- would it be suitable to include that in the tycho-setup directory?

Yes, but what's even more important if we want to enforce/encourage a formatting is that the .settings/ of all modules do reference the same formatter and enable some format on save actions.
Actually, we could stick to the default Eclipse formatter that's built-in (so we wouldn't need to share it) but just ensure we enable this formatter in .settings/

+1000 here. Sticking to built-in formatter is the best option.
 
 
- should I always format the whole file or only edited lines?

I don't think it's important enough for project perspective to make chose one or the other. In general, it's up to the developer to do what's best for them, they're trusted to do the right thing and the project doesn't force a workflow or another. 

-- 
Mickael Istria
https://www.eclipse.org/downloads/eclipse-packages/ developer, for https://developers.redhat.com/
_______________________________________________
tycho-dev mailing list
mailto:tycho-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/tycho-dev


-- 
Alexander Kurtakov
Red Hat Eclipse Team


Back to the top