[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [tycho-dev] Effect of showWarnings?

hm. the relevant code:

       if (!config.isShowWarnings()) {
            args.add("-nowarn");
        }

seems to forward only the showWarnings=false case to the JDT batch compiler
http://help.eclipse.org/luna/index.jsp?topic=%2Forg.eclipse.jdt.doc.user%2Ftasks%2Ftask-using_batch_compiler.htm

the problem with "showWarnings" is it is API from maven compiler plugin and just a boolean is very unspecific, JDT doesn't have a simple boolean but rather allows very fine-grained warnings configuration.

as to useProjectSettings, I guess it's a matter of precedence. If useProjectSettings=true has precedence and warnings are configured there, it should show warnings.
Essentially we just build up the commandline switches for JDT batch compiler, so much of this is probably simply finding out how JDT batch compiler behaves when given certain parameters.

Jan



> -----Original Message-----
> From: tycho-dev-bounces@xxxxxxxxxxx [mailto:tycho-dev-bounces@xxxxxxxxxxx] On
> Behalf Of Oberlies, Tobias
> Sent: Donnerstag, 26. Februar 2015 10:44
> To: Tycho developers list (tycho-dev@xxxxxxxxxxx)
> Subject: [tycho-dev] Effect of showWarnings?
> 
> Following David's comment below, I played around with the tycho-compiler-
> plugin showWarnings parameter [1], and I'm not sure I understood its effect.
> 
> I've set up a little example in the bundles/bundle-1 project in this Github
> project [2], and it seems that showWarnings has no effect: Warnings are
> logged if and only if useProjectSettings=true. I.e. with showWarnings=true
> and useProjectSettings=false, *no* warnings are logged, and with
> showWarnings=false and useProjectSettings=true, the warnings are logged
> *anyway*.
> 
> 
> Another observation was that the warnings in the configured -log file and the
> console log are always identical. From David's comment below, I first thought
> that showWarnings is only supposed to affect the console log output.
> 
> So am I missing anything, or is showWarning in fact broken/useless?
> 
> Cheers
> Tobias
> 
> 
> [1] http://www.eclipse.org/tycho/sitedocs/tycho-compiler-plugin/compile-
> mojo.html#showWarnings
> [2] https://github.com/oberlies/tycho-testbed/tree/compileLog
> 
> -----Original Message-----
> From: bugzilla-daemon@xxxxxxxxxxx [mailto:bugzilla-daemon@xxxxxxxxxxx]
> Sent: Mittwoch, 25. Februar 2015 19:43
> To: Oberlies, Tobias
> Subject: [Bug 460487] tycho.compiler-plugin overwrites compiler log output,
> if more than one jar in a bundle
> 
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=460487
> Product/Component: Tycho / Core
> 
> --- Comment #24 from David Williams <david_williams@xxxxxxxxxx> ---
> (In reply to Tobias Oberlies from comment #21)
> 
> > ... From what I could see,
> > setting -log only enables additional logging. It e.g. doesn't disable the
> > output to the console log.
> 
> Yes, thought I should point out that
> <showWarnings>true</showWarnings>
> controls compiler warnings being printed in the console log.
> 
> My preference would be to leave that as is, and then *add* this new
> functionality, even if a little redundant -- if nothing else, can provide a
> sanity check that the two agree with each other? Not to mention, I'm sure
> some
> in community are "used to" having the <showWarnings>. I assume that is
> implemented differently as well ... as a "listener" of some sort? (i.e. not
> all
> the same information is printed, as when -log is specified to batch compiler,
> such as literal parameters, totals, access warnings, etc.
> 
> Just wanted to be explicit.
> 
> --
> You are receiving this mail because:
> You are on the CC list for the bug.
> You are watching the assignee of the bug.
> _______________________________________________
> tycho-dev mailing list
> tycho-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://dev.eclipse.org/mailman/listinfo/tycho-dev