[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [tycho-dev] [VOTE] Maven 3.2.4 Release

to be fair, I think we are casting on the implementation class instead of using the interface in Tycho.

We need access to configured java home. Unfortunatley the interface JavaToolChain has all methods commented out, so it's of no use.

One way around this may be to read the low-level XPP3 dom configuration elements from toolchains.xml only (we do this in other places already I think), using ToolchainPrivate.getModel(); not sure if this is API or more stable either.

Regards,
Jan


> -----Original Message-----
> From: tycho-dev-bounces@xxxxxxxxxxx [mailto:tycho-dev-bounces@xxxxxxxxxxx] On
> Behalf Of Igor Fedorenko
> Sent: Samstag, 13. Dezember 2014 00:39
> To: dev@xxxxxxxxxxxxxxxx
> Cc: Tycho developers list
> Subject: Re: [tycho-dev] [VOTE] Maven 3.2.4 Release
> 
> Unfortunately, I have to take this back. The changes to toolchain
> broke Tycho and, short of using reflection, I don't see how
> to make Tycho work with maven 3.2.4 and earlier versions of Maven.
> 
> For better or worse,
> org.apache.maven.toolchain.java.DefaultJavaToolChain was part of
> Maven API since 2.x and I don't think we can just remove the class.
> 
> I see two ways to fix this. Either we rename the classes back, which is
> probably the easiest. Or we introduce deprecated DefaultJavaToolChain
> that extends the new implementation.
> 
> Here is my -1 for releasing 3.2.4 in its current state.
> 
> --
> Regards,
> Igor
> 
> On 2014-12-12, 18:01, Igor Fedorenko wrote:
> > +1
> >
> > --
> > Regards,
> > Igor
> >
> > On 2014-12-12, 16:54, Jason van Zyl wrote:
> >> Hi,
> >>
> >> Time to release Maven 3.2.4!
> >>
> >> Here is a link to Jira with 20 issues resolved:
> >>
> https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500&version=205
> 74
> >>
> >>
> >> Staging repo:
> >> https://repository.apache.org/content/repositories/maven-1102/
> >>
> >> The distributable binaries and sources for testing can be found here:
> >> https://repository.apache.org/content/repositories/maven-
> 1102/org/apache/maven/apache-maven/3.2.4/
> >>
> >>
> >> Specifically the zip, tarball, and source archives can be found here:
> >> https://repository.apache.org/content/repositories/maven-
> 1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.zip
> >>
> >> https://repository.apache.org/content/repositories/maven-
> 1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.tar.gz
> >>
> >> https://repository.apache.org/content/repositories/maven-
> 1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-src.zip
> >>
> >> https://repository.apache.org/content/repositories/maven-
> 1102/org/apache/maven/apache-maven/3.2.4/apache-maven-3.2.4-src.tar.gz
> >>
> >>
> >> Source release checksum(s):
> >> apache-maven-3.2.4-src.zip sha1: db5fb9feda693f05fe7effaf096d6cd4dd5eff44
> >>
> >> Staging site:
> >> http://takari.io/maven-3.2.4/
> >>
> >> Vote open for 72 hours.
> >>
> >> [ ] +1
> >> [ ] +0
> >> [ ] -1
> >>
> >> Thanks,
> >>
> >> The Maven Team
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxxxx
> >> For additional commands, e-mail: dev-help@xxxxxxxxxxxxxxxx
> >>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxxxx
> > For additional commands, e-mail: dev-help@xxxxxxxxxxxxxxxx
> >
> _______________________________________________
> tycho-dev mailing list
> tycho-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://dev.eclipse.org/mailman/listinfo/tycho-dev