Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [tycho-dev] tests fail, surefire reports the failures, tycho-surefire declares the build success

The issue in Tycho is very much reproducible [1], but I think the root
cause is in Luna Platform, not in Tycho. There either was an API change
we were not aware of or a bug was introduced in the way Platform UI test
harness works in Luna.

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=436042

--
Regards,
Igor

On 2014-05-28, 5:54, Sievers, Jan wrote:
it seems the issue is not reproducible:

http://ci.takari.io:8080/job/m2eclipse-tycho/38/console

we rely on the process exit code, so the only way I could imagine this could happen is either

a) System.exit(0) somewhere during test execution
b) for some reason the process exit code returned by commons-exec is 0 although it should be != 0

I'm afraid without steps to reproduce we can't analyse this.

An idea to think about maybe is to add a "safety net" and don't rely on process exit 0 for declaring test success code but rather parse surefire XML reports (if available) to see if any tests failed.

Jan

-----Original Message-----
From: tycho-dev-bounces@xxxxxxxxxxx [mailto:tycho-dev-bounces@xxxxxxxxxxx] On Behalf Of Sievers, Jan
Sent: Mittwoch, 28. Mai 2014 10:16
To: Tycho developers list
Subject: Re: [tycho-dev] tests fail, surefire reports the failures, tycho-surefire declares the build success

please open a bug

Jan

-----Original Message-----
From: tycho-dev-bounces@xxxxxxxxxxx [mailto:tycho-dev-bounces@xxxxxxxxxxx] On Behalf Of Igor Fedorenko
Sent: Dienstag, 27. Mai 2014 22:07
To: Tycho developers list
Subject: [tycho-dev] tests fail, surefire reports the failures, tycho-surefire declares the build success

I updated m2e-tycho build to the latest version tycho 0.20, among other
things. Much to my surprise, build log both says there were test errors
and failures and "All tests passed!" [1]. I don't think this is related
to #434648 because in this case the tests run and a few even succeed.

What makes this really bad, I noticed the failures by accident and could
easily miss them for very very long time. This really looks like 0.20.1
material, to be honest.


[1] http://ci.takari.io:8080/job/m2eclipse-tycho/33/console

--
Regards,
Igor
_______________________________________________
tycho-dev mailing list
tycho-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/tycho-dev
_______________________________________________
tycho-dev mailing list
tycho-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/tycho-dev
_______________________________________________
tycho-dev mailing list
tycho-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/tycho-dev



Back to the top