| Re: [tracecompass-dev] Style properties minor changes in 2020-09 |
|
Hi Patrick
thanks for letting us know. I think it's fine to change this.
BR
Bernd
From: tracecompass-dev-bounces@xxxxxxxxxxx <tracecompass-dev-bounces@xxxxxxxxxxx> on behalf of tracecompass developer discussions <tracecompass-dev@xxxxxxxxxxx>
Sent: July 28, 2020 2:00 PM To: tracecompass developer discussions <tracecompass-dev@xxxxxxxxxxx> Subject: [tracecompass-dev] Style properties minor changes in 2020-09 Hi,
The following changes in the handling of some StyleProperties values in 2020-09 may affect users of Trace Compass that use styles in their data provider implementation:
- HEIGHT
For symbol markers (annotations) in time graph and xy chart, the implementation is changed so that the default value of 1.0f (normal element height) corresponds to a height equal to the item (row) height in a time graph, and the default symbol size (half-height
of 4 pixels) in a xy chart.
For a time graph this is half the size of current implementation. Users that set the HEIGHT property should double the value to obtain the same symbol size.
For a xy chart the HEIGHT property was not supported yet in current implementation, except in the legend column where 1.0f corresponded to a symbol size of 1 pixel.
- WIDTH
Arrows width is now set using the WIDTH property in pixels (default: 1). For backward compatibility, if and only if WIDTH is not set then the HEIGHT property is used where value 0.1f corresponds to an arrow width of 1 pixel, as in the current implementation.
- COLOR
For arrows and symbols, the COLOR property is still used as in the current implementation, however it is no longer necessary to also set the BACKGROUND_COLOR for the legend to work properly. The BACKGROUND_COLOR is still used to set the state color in
a time graph.
These changes are already merged in the master branch.
Patrick
|