[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[tracecompass-dev] Use of deprecated and discouraged access APIs

Hi
I had a discussion a while ago with Matthew about our plugin's use of some Trace Compass classes and methods that are Trace Compass internal classes and the possibility of making those classes part of the public API.

Following up on this, I set the message level for the discouraged and deprecated uses to Error to be sure I didn't miss anything. I got the following list using the http://download.eclipse.org/tracecompass/photon/milestones/ur3_m2/ build.

Discouraged access: The constructor 'CallStackDataProvider(ITmfTrace, CallStackAnalysis)' is not API
Discouraged access: The constructor 'CallStackEntryModel(long, long, String, long, long, int, int)' is not API
Discouraged access: The method 'AbstractTmfTraceDataProvider.computeRegexPredicate(TimeGraphStateQueryFilter)' is not API
Discouraged access: The method 'AbstractTmfTraceDataProvider.getTrace()' is not API
Discouraged access: The method 'AbstractTreeDataProvider<CallStackAnalysis,CallStackEntryModel>.getAnalysisModule()' is not API
Discouraged access: The method 'AbstractTreeDataProvider<CallStackAnalysis,CallStackEntryModel>.getId(int)' is not API
Discouraged access: The method 'AbstractTreeDataProvider<CallStackAnalysis,CallStackEntryModel>.getSelectedEntries(SelectionTimeQueryFilter)' is not API
Discouraged access: The method 'AbstractTreeDataProvider<CallStackAnalysis,CallStackEntryModel>.getTimes(TimeQueryFilter, long, long)' is not API
Discouraged access: The type 'CallStackDataProvider' is not API
Discouraged access: The type 'CallStackEntryModel' is not API
Discouraged access: The type 'TimeGraphStateQueryFilter' is not API

I did not get any errors for use of deprecated classes or methods

I also ran a recursive grep of my source and found three instances where I import a class with '.internal.' as part of its name

import org.eclipse.tracecompass.internal.analysis.profiling.core.callstack.provider.CallStackEntryModel;
import org.eclipse.tracecompass.internal.analysis.profiling.core.callstack.provider.CallStackDataProvider;
import org.eclipse.tracecompass.internal.tmf.core.model.filters.TimeGraphStateQueryFilter;

Are you willing to make any of the above part of the published Trace Compass API? I realize that it's probably too late for Trace Compass 4.3. Is this a possibility for Trace Compass 5.0?

Thanks

Dave