Re: [tracecompass-dev] Using apache.commons.lang3

[Alexandre Montplaisir <alexmonthy@xxxxxxxxxxxx>]

Makes sense to reuse code whenever we can. I'm not against adding the 
dependency if it's useful (it's easy to add dependencies with Maven!). 
I'm just a little worried that we might start using Guava Strings.* 
sometimes and Apache StringUtils.* other times for the same functionality.


On 2015-08-19 05:30 PM, Marc-André Laperle wrote:
> Pair was just an example, but still it would be better to reuse an implementation like Apache's than maintaining our own. I wanted to use ExceptionUtils.getStackTrace() for better error dialogs and JUnit failures. This is not in Guava. We have an implementation in AbstractTracePackageWizardPage that I can put in common.core if we want. But that adds it to the list of things we could replace with Apache's implementation.
>
> Marc-Andre
>
> ________________________________________
> From: Alexandre Montplaisir [alexmonthy@xxxxxxxxxxxx]
> Sent: Wednesday, 19 August 2015 5:24 PM
> To: Marc-André Laperle
> Cc: tracecompass developer discussions
> Subject: Re: [tracecompass-dev] Using apache.commons.lang3
>
> Hi Marc-André,
>
> Guava and Apache Commons have a lot of overlap. Are the things you are
> looking for not already in Guava?
>
> About Pair, we already have an implementation in the tree. Although I'd
> argue that Pair is bad practice, and that you are usually better off
> implementing your own compound objects ;)
>
> Cheers,
> Alex
>
>
> On 2015-08-19 05:11 PM, Marc-André Laperle wrote:
> > Hi,
> >
> > I'd like to start making use of apache.commons.lang3 from Orbit.
> > There are a few things useful, like StringUtils.EMPTY, Pair, ExceptionUtils.getStackTrace() and probably more.
> >
> > You can find the javadoc here:
> > https://commons.apache.org/proper/commons-lang/javadocs/api-release/index.html
> >
> > If there are no objections, I will create a CQ for this.
> >
> > Marc-Andre
> >
> >
> >
> > _______________________________________________
> > tracecompass-dev mailing list
> > tracecompass-dev@xxxxxxxxxxx
> > To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> > https://dev.eclipse.org/mailman/listinfo/tracecompass-dev