Re: [tracecompass-dev] Moving plugins to component sub-directories

[Matthew Khouzam <matthew.khouzam@xxxxxxxxxxxx>]

And that would solve partially the tangle to which I was referring. I
think this would be an awesome patch to welcome Neon. I don't see us
having the bandwidth to get it in now.

On 15-05-05 02:42 PM, Alexandre Montplaisir wrote:
> On 2015-05-05 02:16 PM, Matthew Khouzam wrote:
>>
>> On 15-05-05 02:05 PM, Alexandre Montplaisir wrote:
>>> On 2015-05-05 12:51 PM, Matthew Khouzam wrote:
>>>> Hi,
>>>>
>>>> This is super interesting and exciting.
>>>>
>>>> I would suggest we fix package tangle between the components before
>>>> going forward though. If not it will look like spaghetti dangling from
>>>> many pots instead of one.
>>> It's completely orthogonal to packaging tangling. The package names or
>>> contents do not change.
>> I kinda sorta disagree on that point.
>>
>> I will use oe.tmf.ctf.core as an example
>> It points to the internals of CTF.
>> It would probably go into TMF as it is TMF.ctf
>
> No, the CTF plugin for TMF is part of the "CTF" component, and would
> go under ctf/. It should be renamed "ctf.tmf" to better illustrate
> this, but I didn't want to push too many changes at the same time :)
>
> Basically it's to have all the bubbles in
> https://git.eclipse.org/c/tracecompass/org.eclipse.tracecompass.git/plain/plugins.svg
> to be in separate sub-directories, except ctf.tmf and pcap.tmf (future
> names), those are part of CTF and pcap respectively.
>
>> We should cut dependencies on internals first. Would you have a better
>> term for this? Maybe project tangle?
>>
>> Matthew
>>> Splitting tmf.core/ui in separate plugins though, that will reduce
>>> package/plugin tangle. But doing this will be less messy to do if
>>> "TMF" is in its own sub-directory already.
>>>
>>> Cheers,
>>> Alex
>>>
>>>> Br
>>>> Matthew
>>>>
>>>> On 15-05-04 07:02 PM, Alexandre Montplaisir wrote:
>>>>> Hi all,
>>>>>
>>>>> I'm currently looking at moving all plugin directories in the source
>>>>> tree to separate "component" directories. Like was done for doc/
>>>>> already, so that eventually top-level would only contain:
>>>>>
>>>>> btf/
>>>>> ctf/
>>>>> doc/
>>>>> lttng/
>>>>> tmf/
>>>>> ...
>>>>>
>>>>> Some are not immediately clear where they should go (examples,
>>>>> releng-site,...) but we'll see once we get there. ;)
>>>>>
>>>>> I started with the BTF component, since it's quite simple and
>>>>> standalone:
>>>>> https://git.eclipse.org/r/#/c/47104/
>>>>> https://git.eclipse.org/r/#/c/47105/
>>>>>
>>>>> As explained in the first patch, I've renamed the feature plugins to
>>>>> "*.feature". We've talked about adding the ".feature" to feature
>>>>> plugin names previously, this is a good occasion to do so, since it
>>>>> will free the o.e.t.{btf|ctf|...} names for the directories
>>>>> themselves. I've added the previous names to the p2.inf files, so
>>>>> that
>>>>> upgrades should follow the rename.
>>>>>
>>>>> Is there anything else that could have slipped my mind?
>>>>>
>>>>> I'm quite certain that this won't be all done in time for the feature
>>>>> freeze, as more complex plugins with test traces and such will take
>>>>> more time. Are we fine with just btf/ and pcap/ in 1.0, and the rest
>>>>> later once stable-1.0 is branched?
>>>>>
>>>>>
>>>>> Cheers,
>>>>> Alexandre
>>>>>
>
> _______________________________________________
> tracecompass-dev mailing list
> tracecompass-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or
> unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/tracecompass-dev