Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [tracecompass-dev] ControlFlowView - TimeGraphFilterDialog - Uncheck inactive

Hi Genevieve.
Thanks for your reply! Apart from the new API I still think this is a valuable feature. What's the time frame we are looking at here? I guess three more months until the new API arrives is OK. A year on the other hand seems pretty long ... I would be happy to submit a patch incorporating the installable button feature. If you still don't like it, simply dismiss it ...
Regards Chris.


Am 27.02.2015 um 15:36 schrieb Geneviève Bastien:
Hi Chris,

A patch like that has already been proposed last year here:
https://git.eclipse.org/r/#/c/19262/

If I recall, apart from the review comments, it was dismissed back then
because the filter dialog was meant to be replaced by a new filter API
that will be much more flexible and universal for all views. But that is
yet to come, and in the meantime, if there is demand, this patch could
be ported to Trace Compass. And when the filter API arrives, it can then
be quietly removed from the code-base.

Cheers,
Genevieve



On 02/27/2015 08:12 AM, christian mansky wrote:
Hi Everyone,
I'd like to propose an enhancement to the ControlFlowView that affects the TimeGraphFilterDialog (the dialog where one can check and uncheck threads to be shown). I'd like to show 2 new Buttons saying 'Uncheck inactive' and 'Check active'. The idea is to select a time frame in the ControlFlowView to which the user wants to take a closer look. Upon selecting 'Uncheck inactive' all 'inactive' threads of this time frame are to be hidden (or all active threads to be shown, for that matter).
A thread is considered active when in usermode, executing a syscall or when currently executing an interrupt. I realize the interesting part (architecture-wise) here is the abstraction of the ControlFlowView from the TimeGraphFilterDialog, or more specific, how the ControlFlowView presents its functionality to the TimeGraphFilterDialog.

So before going into too many details, I'd like to know if this is something you consider a useful enhancement. I've seen something similar years ago in a scheduling viewer tool and came to appreciate it very much.

Regards Chris.
_______________________________________________
tracecompass-dev mailing list
tracecompass-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/tracecompass-dev
_______________________________________________
tracecompass-dev mailing list
tracecompass-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/tracecompass-dev




Back to the top