Re: [theia-dev] Failing license checks on PR's

[Thomas Mäder <t.s.maeder@xxxxxxxxx>]

Merging PRs is fine, but I would expect the foundation would frown upon doing a release with the IP checks failing, no? Isn't it up to the foundation to say if it's a false positive or not in this process?

/Thomas

------ Original Message ------

From "Marc Dumais" <marc.dumais@xxxxxxxxxxxx>

To "theia developer discussions" <theia-dev@xxxxxxxxxxx>; "Thomas Mäder" <t.s.maeder@xxxxxxxxx>

Date 29/03/2023 15:14:52

Subject Re: [theia-dev] Failing license checks on PR's

Hi Thomas,

I will  have a look.

The license check is not configured as mandatory to pass, so if we believe that it fails because of a false-positive, we can go ahead with the release (or merging a PR in general).

Regards,

Marc

---

From: theia-dev <theia-dev-bounces@xxxxxxxxxxx> on behalf of Thomas Mäder <t.s.maeder@xxxxxxxxx>
Sent: Wednesday, March 29, 2023 6:14 AM
To: theia developer discussions <theia-dev@xxxxxxxxxxx>
Subject: [theia-dev] Failing license checks on PR's

 

Hi folks,

I've noticed the license checks on our builds have started failing. I've found https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/7694. Can someone with insight into the problem explain what's happened and how we're going forward? The dependency it complains about has been present since mid-February :shrug:

Am I right to say this blocks tomorrow's release if not resolved?

/Thomas