Re: [stem-dev] EMF addition

[Stefan Edlund <edlund@xxxxxxxxxxxxxxx>]

Hi Bryan,

this looks like a great start. I didn't apply and check in the patch yet since I'm holding off on check-ins until the release is done.

As for your questions, the toTooltipString() method needs to be overridden by subclasses that displays labels on the tooltip, i.e. SILabelImpl, SIRLabelImpl, SEIRLabelImpl and TBDiseaseModelLabelImpl. So you would display the population identifier and then the value for each compartment. There is no need to display the total size of the population.

Regards,
/ Stefan

Stefan Edlund
Public Health and Computer Science Research
IBM Almaden Research Center
(408) 927-1766 edlund@xxxxxxxxxxxxxxx


Bryan Hobbs ---04/09/2011 07:02:16 PM---Hey Guys, I created and submitted a patch for the EMF addition and disease label

From:	Bryan Hobbs <bry.hobbs@xxxxxxxxx>
To:	Stefan Edlund <edlund@xxxxxxxxxxxxxxx>, James Kaufman <kaufman@xxxxxxxxxxxxxxx>
Cc:	Justin Duperre <jduperre@xxxxxxxxx>
Date:	04/09/2011 07:02 PM
Subject:	EMF addition

---

Hey Guys,

I created and submitted a patch for the EMF addition and disease label identifier https://bugs.eclipse.org/bugs/show_bug.cgi?id=342360

Hopefully I did everything correctly. I added a toTooltipString operation to the EMF as a standardDiseaseModelLabel child. Made the default toTooltipString return toString. And moved all the overiding toTooltips to their coorespinding Label files, adding the population identifier. 

Some things to question.
1. Should the default divert to the toString() as these are really ugly and too long for the tooltip.
2. Should the population identifier remain as is. I.E should it contain the population size too, kind of redundant. 

Thanks,
Bryan Hobbs