[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
[stellation-res] TClient bugfix
|
I installed the TClient repository code on stellation.eclipse.org on
Friday, and all JUnit tests passed with flying colors......
I then tried checking in the current Stellation source code, as one final
test before switching from the test db to the regular stellation db and
releasing the TClient for use by committers.
Murphy strikes again! It turned out that some of my local files had
apparently been damaged (most likely by a gvim crash) and now contained
blocks of nulls (>6400 contiguous nulls in one case). The Text Artifact
design can't handle this, and both server and client hang when such a file
is processed. GIGO .....
The full details are in Bugzilla #59155. I've put in a somewhat kludgy
fix: any text line containing nulls is simply discarded when a Text
instance is created for a TextArtifact. This potentially means some valid
content might be lost (i.e. if a single text string contains both a run of
nulls and valid character content). However, it's not clear to me that a
better fix is worth investing time in, given the context (problem only
happens for already-malformed files, this code is transitional, the WVCM
client will have better error recovery...)
Please comment if you think that the TClient should incorporate a better
fix (and feel free to contribute a code snippet that will appropriately
reconstruct a malformed text line). In the meantime, I'm going to strip
some debug scaffolding out of TextArtifact and related classes, and then
proceed with bringing up the TClient and associated server.
- Jim
--
Jim Wright, IBM T.J. Watson Research Center
*** The Stellation project: Advanced SCM for Collaboration
*** http://www.eclipse.org/stellation
*** Work Email: jwright@xxxxxxxxxxxxxx ------- Personal Email:
jim.wright@xxxxxxx
