[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
[stellation-res] Initial steps
|
The first thing I would like to do once we have the contents of the
repository stabilized is to do a pass removing all the warning messages
generated by Eclipse. Currently there are more than 200 of these and they
really clutter up the problem list. I would like to do this before we create
any branches so that we start off with a clean base.
The most troubling problem in this exercise is unfortunately fairly common.
There are numerous places where a variable is set from a method return but
the method also sets internal state in the object. If the method is named
get... it is no clear without looking at its' code whether there are side
effects. I propose that such methods be renamed to acquire... With this
convention, it will always be obvious to the reader what is happening
without the need to examine extraneous code.
It will only take a few hours to do this edit once we have the repository
contents firmed up.
Regards
Jonathan Gossage
