[stellation-res] Bugzilla 34471: Redesign of RevisionSelectionDialog and

[Jim Wright - IBM Research <jwright@xxxxxxxxxxxxxx>]

I have just posted a new attachment for Bugzilla 34471: "Comment HoverText
in Revision Selection dialog does not yield focus".  This is actually a
fairly substantial refactoring of the underlying mechanisms managing
Branches and Revisions within the Eclipse client, and also includes various
fixes and workarounds for SWT/JFace-related issues.

Please Note: I am continuing to work in this area.
It would be _very_ helpful if someone could verify this patch set soon; 
otherwise
I will probably need to simply check in the changes and move on.

------------------------------------------------------------------------------

Specific changes include:
- restores hovertext comments,
- uses F2 key to popup comment display without hover delay
- Removes popup ("infopop") on any keystroke, or when mouse exits infopop
- Refactors Revision and Branch Items (scm.model) and Elements (scm.ui) to
share functionality and interface for common properties.
- Adopts use of Date (rather than raw epoch-milli string) for timestamps
- Formats timestamp in RevisionSelection dialog using current locale.

This patch set includes significantly altered derivatives of several JFace
classes (notably AbstractHoverInformationControlmanager and
DefaultInformationControl).  Changes were required to accomplish correct
behaviour with the GTK SWT implementation, and to enhance the
InformationControl to provide additional mechanisms to remove the
InformationControl (infopop), e.g. from keystrokes or mouseExit events; the
ExtendedInformationControl also provides access to its Shell and StyledText
components, so that additional Listeners can be added.

As per the initial patch, the Revision Selection dialog presents more (and more
structured) information than did the pre-March version of this dialog.

A related change should be made when the Stellation Preferences page is next
modified: there should be a user preference to enable/disable the mouse hover
event trigger for the infopop display (some have found this feature annoying).

- Jim
--
Jim Wright, IBM T.J. Watson Research Center
*** The Stellation project: Advanced SCM for Collaboration
*** http://www.eclipse.org/stellation
*** Work Email: jwright@xxxxxxxxxxxxxx ------- Personal Email: 
jim.wright@xxxxxxx