[stellation-res] Code review process

["Jonathan Gossage" <jgossage@xxxxxxxx>]

There seem to be some problems with the current patch based code review
process which center on the patches themselves. I would like to propose an
alternate possibility which would have the side effect of taking us closer
to the process that we will likely adopt once we start self-hosting.

The proposal relies on the use of multiple workspaces and on the use of file
deltas instead of patch files.

It could work like this.

1. Create a base workspace. This workspace would be kept in sync with the
repository but would never have local modifications made to it. This
workspace would be used for quickly creating clones in which actual work
would be done.

2. Create a separate workspace for each work element such as a bugzilla fix
or enhancement.

2, When ready to submit a patch, create a zip file that contains copies of
all files changed while developing the patch.

3. The reviewer creates a new workspace when the patch is received and
unzips the patch into the workspace. The patch can then be reviewed and
tested.

4. Once a patch has been verified it can be checked into CVS by either the
reviewer or the originator of the patch.

This process should get around the problems of creating patch files that
cannot be applied.

Thoughts


Regards

Jonathan