Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [stellation-res] #34471 Comment HoverText: Patch Posted

I have just posted a patch containing a redesign of the Revision Selection
dialog (Bugzilla #34471).  Hovertext is no longer used for comment display.

Instead, the dialog uses a TableTree viewer, which supports column-segmented
nodes (like a Table) which are both collapsible and hierarchically ordered
(like a Tree).

As part of this change, I have enhanced the dialog to display more
information.  This includes:
* Name / ID (Branch Name or Revision Number)
* Checkin timestamp (using default locale and Date-Time format)
* Comment, if available
* Author

There is also a header bar with column titles and separators, which may be
dragged to change column widths.

Currently, comment text is clipped if it exceeds the allotted screen space.
Some means for displaying the full comment text should be added.
Possibilities include:
* Right-clicking and/or single-clicking over a comment field to open a
  multi-line text display.
* Adding a small button on the right side of each comment field; clicking
  the button would open the multi-line text display on the associated comment.

Please let me know which alternative you would prefer, or suggest a different approach.

Also - I'd appreciate it if someone would verify the patch so I can check it in (the current
code in CVS is rather broken, I'm afraid....).

Regards,

Jim

At 03:05 PM 3/12/2003, Jim Wright - IBM Research wrote:
Earlier today, I installed GTK 2.0.9 and rechecked the 'comment hovertext' problem.
It still occurs.
I have not yet tried GTK 2.2.1, but am probably not going to do so, at least for now. Reason: it seems wiser to try something new, since Mark and Jonathan aren't wild
about hovertext (at least as currently used for displaying comments).

I'd like to try a different approach: using a TableTree widget for selecting
revisions and displaying revision attributes (date, comments, author...)
This avoids the use of hovertext completely, and will probably provide more
consistent look & feel with Eclipse platform conventions.  (for example, the
PropertySheet viewer uses a TableTree widget).  The TableTree widget also
supports cell (field) editors, which is likely to be useful.

I will start working on a trial TableTree-based implementation shortly, unless
someone has a better suggestion.  Once a rough version is prototyped,
I'd like to get feedback and refine as needed.

Since hovertext (and hover widget panels) still seem useful for other purposes, I will also post a Bugzilla report and see if the SWT GTK team can get it resolved.

Regards,
Jim


--------------------------------------------------------------------
Jim Wright, IBM T.J. Watson Research Center
*** The Stellation project: Advanced SCM for Collaboration
*** http://www.eclipse.org/stellation
*** Work Email: jwright@xxxxxxxxxxxxxx ------- Personal Email: jim.wright@xxxxxxx



Back to the top