| Re: [stellation-res] Reactivate the Oracle backend. |
On Tue, 2002-09-24 at 22:21, Ringo De Smet wrote:
> Hello,
>
> Just to let you all know I tried to reactivate the Oracle backend.
Great to have you back!
> However, I do have some remarks and problems:
>
> 1) AbstractDBAccessPoint should be renamed: the class is no longer
> abstract!
The reason I left the name that way is because it's an access point
based on an abstract database object. I have no objection to just
making it "DatabaseAccessPoint" if others prefer it. If you want to,
go ahead and change it.
> 2) In the constructor of AbstractDBAccessPoint, I added this:
> if (_dbkind.equals("oracle")) {
> _db = new OracleDatabase(this, location);
> }
> Is the the correct way to do?
Currently, yes. If I recall the discussion, there was some general
agreement that statically coding these things was wrong, and there
should be a Stellation configuration file that maps prefixes onto
access point types. I haven't had time to write it, so for now,
that's the way to do it.
> However, the db type is removed from location in the first line of this
> constructor. In the constructor of BasicDatabase, the database name is
> removed from location and I had to change the OracleDatabase for the
> creation to work. I strongly dislike the StringList location argument.
> As an argument, it doesn't tell you much: the code should be the most
> up to date documentation there is!
Sorry... I could have sworn I updated the documentation there to
explain what the stringlist in the location argument was... I'll try
to check up what's there, and try to make the documentation for it
clearer.
> 3) The creation of the the repository fails. I have changed the
> s_Comments table to have column s_comment as VARCHAR2(4000). But then
> the next insert statement fails. Why is this INSERT statement needed?
I'm not sure - the comments table is Dave's addition. Do you know
why it's failing? Even if we take out this insert here, if someone
provides an empty comment on a checkin, then the checkin is going
to execute that statement (with a different comment id).
-Mark
--
Mark Craig Chu-Carroll, IBM T.J. Watson Research Center
*** The Stellation project: Advanced SCM for Collaboration
*** http://www.eclipse.org/stellation
*** Work Email: mcc@xxxxxxxxxxxxxx ------- Personal Email: markcc@xxxxxxxxxxx
Attachment:
signature.asc
Description: This is a digitally signed message part