| Re: [starter-dev] Initial Jakarta EE 11 Support |
Great - in the master branch now. I'll follow-up with the Maven
project also when time permits. Hopefully we can avoid something
too bespoke longer term.
Hi Reza,
I found the issue with Velocity indentation, PR to the velocity-indentation-experiment branch here:https://github.com/eclipse-ee4j/starter/pull/346.
The Antrun plugin which un-indents Velocity template files, was not executed at all. It was defined in pluginManagement but not in plugins. I also added support for un-indenting Velocity comments, which start with ##. There are a few lines with them that started with spaces. I checked the Velocity template files in the final archetype, and all the Velocity macros start at the beginning of the line, without any spaces before.
Ondro
On Mon, Jan 20, 2025 at 8:01 PM Ondro Mihályi <mihalyi@xxxxxxxxxxx> wrote:
Hi Reza,
OK. Velocity 2.0 indeed supports indentation by default, but the Maven archetype plugin forces it to use the old behavior of Velocity 1 and there's no way to configure it: https://github.com/apache/maven-archetype/blob/e8b9f29f2fb385111f272b2ded012c5f9ddf3ba8/archetype-common/src/main/java/org/apache/maven/archetype/VelocityConfigurator.java#L45
When I have some time, I'll try to address the remaining issues in the experimental branch you created.
Ondro
On Sun, Jan 19, 2025 at 7:42 PM Reza Rahman <reza_rahman@xxxxxxxx> wrote:
Ondro, when you are able to resume this work, please issue PRs here: https://github.com/eclipse-ee4j/starter/tree/velocity-indentation-experiment. For now I have reverted the attempt to indent the Velocity code so we can move forward with a Jakarta EE 11 release. As time permits, I will also pursue this with the Maven project. As I understand it, newer versions of Velocity support indentation by default.
Jeyvison, can we kindly have a release of the Archetype into Maven Central? I have off tomorrow for MLK day and I am hoping I can get the UI work done so we can get EE 11 fully rolling. It looks like we can soon add support for the Web Profile too.
On 1/12/2025 7:42 PM, Reza Rahman wrote:
The code is in main as I believe it is almost there: https://github.com/eclipse-ee4j/starter. The issue as I mentioned is that the leading spaces in Velocity are not really all gone (it appears some are, but some aren't). Maybe the RegEx isn't quite correct: https://github.com/eclipse-ee4j/starter/blob/78f292b32bdfad215f61465490c9fe697088a78a/archetype/pom.xml#L139?
When you generate the code, you will see issues in the pom.xml, README.md, Dockerfile, etc.
On 1/12/2025 6:42 PM, Ondro Mihályi wrote:
OK, I can have a look. What issues do you have or what you want to do? Do you have your code in some branch?
Ondro
On Mon, 13 Jan 2025 at 00:11, Reza Rahman <reza_rahman@xxxxxxxx> wrote:
Hi Ondro,
I really need your help with the enhancement to add indentation to the
Velocity code. I have tried various things, but just can't seem to get
it to work correctly. There are always inexplicable white spaces that
ultimately break thing in the end in the generated code.
Do you think you have time to look into this? Otherwise I am going to
revert these changes and just stick to the indentation approach that has
been working. I do want to get the EE 11 release out ASAP.
Thanks,
Reza
On 12/22/2024 6:20 PM, Reza Rahman wrote:
> Hi folks,
>
> I’ve now finished adding initial Jakarta EE 11 support to the
> archetype in the default branch. I also had to make some overdue
> changes to fix edge case bugs that were made worse by adding EE 11 and
> SE 21. I tried my best to update the nightly tests as well as test
> manually (as the automated tests are still far from complete). I think
> I caught everything but I am not sure. So can I ask that everyone
> spend some time testing?
>
> In the meantime, I am going to work on getting EE 11 support in the
> UI. The UI also needs to be upgraded to EE 10, which is now available
> on Azure. I am hoping to be done by the new year so we can have a
> release. I think we should keep the release quiet until EE 11 official
> announcements are actually sorted out.
>
> Cheers,
> Reza