Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [servlet-dev] [TCK Challenge] dispatchAfterCommitTest5
  • From: Manfred Riem <m_riem@xxxxxxxxxxx>
  • Date: Tue, 6 Dec 2022 23:03:42 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7F6+1uqUGIiLeDEe9lYxMhIvB0PwVwUwtu/JsJV+32Q=; b=VGcgSe0sYryQzEjpFBdmOUvU0TTXa18lMY/7LjftOXMGePf7dTR6r8PuMEhf1q4myLSJ9u9piVxTNa9he7mcdQNx+rJWv+Xckv3TcpO9V/GDSlWk3GLXxMvWY+5Zlwzt7ANxN2WavsjiV7UYQRFEYizKmZ/NUgzyS9U94Ypl/ipkYzvTfp4BVGB+HBf+uunn/ZMJTNVQre5amDw2gNQjj6AcqbzdIpBYwXcfdOG+9kslQHJcmNBZGNf210zxo8zpq9Lu2WDPbIFl2ljItRKNIYFhuJCXeHFjzIwjgll/ig0sfkjs7eq0shIEAH2lrxy/eGfdzEX+4wrAXT57oosrmA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cVWaQ5nhee/2Et30bVptQzQrpJFJRmbljfv2UkjqNmpEuk7IJ6145eojlTD2NrWng0PwPGF6PhMoxEqd6Q5XTuALbz7lPWJGpWRGXzYWK1mGb+x/8InmL5l/ZpE1Puq8Gl7FKEjOC+m+bPFYhbFOYWiKl0xNbW81gYkVns1k3ZzKSyU60xkmMiqmTza7wGumerZAgrVrqOGLibjmsIwROzjpRhgmejOfcxViPXEbapbjjuAGQYO6aFyz5Zos6rcNY5yByabcdeoGUHsRS7XtsH/EiR0SCZ6FOe+ZYJ8dA5rhF6d6eSnnPMurEj3Z0w3gjnu579zC0QXrmqYIR2nneQ==
  • Delivered-to: servlet-dev@xxxxxxxxxxx
  • List-archive: <https://www.eclipse.org/mailman/private/servlet-dev/>
  • List-help: <mailto:servlet-dev-request@eclipse.org?subject=help>
  • List-subscribe: <https://www.eclipse.org/mailman/listinfo/servlet-dev>, <mailto:servlet-dev-request@eclipse.org?subject=subscribe>
  • List-unsubscribe: <https://www.eclipse.org/mailman/options/servlet-dev>, <mailto:servlet-dev-request@eclipse.org?subject=unsubscribe>
  • Thread-index: AdkJd25JC8AgmeYeRiCAhTu4grFzTwAIv/AAAAsNxkA=
  • Thread-topic: [servlet-dev] [TCK Challenge] dispatchAfterCommitTest5

Hi Scott,

 

Short answer: yes.

 

Longer answer: working through the details of getting the Piranha project to pass the Servlet TCK. See https://github.com/piranhacloud/piranha/actions/workflows/tck-server.yml

 

Thanks!

 

Kind regards,
Manfred Riem

 

From: Scott Marlow <smarlow@xxxxxxxxxx>
Sent: Tuesday, December 6, 2022 11:45 AM
To: servlet developer discussions <servlet-dev@xxxxxxxxxxx>; Manfred Riem <m_riem@xxxxxxxxxxx>
Subject: Re: [servlet-dev] [TCK Challenge] dispatchAfterCommitTest5

 

Hi,

Manfred, are you currently investigating any additional Servlet 6.0 TCK failures that may lead to more Servlet TCK challenges?  I'm trying to understand if the four accepted Servlet TCK challenges (https://github.com/jakartaee/servlet/issues/486 + https://github.com/jakartaee/servlet/issues/488 + https://github.com/jakartaee/servlet/issues/489 + https://github.com/jakartaee/servlet/issues/490), are the only Servlet TCK challenges to be addressed in a Servlet TCK service release?

The new Servlet TCK service release should be added to the https://jakarta.ee/specifications/servlet/6.0 page as https://download.eclipse.org/jakartaee/servlet/6.0/jakarta-servlet-tck-6.0.2.zip. 

Since the same tests are also in the Platform TCK, we will also want a https://download.eclipse.org/jakartaee/platform/10/jakarta-jakartaeetck-10.0.2.zip as well.

We will also want the jakarta-jakartaeetck-10.0.2.zip service release to address https://github.com/jakartaee/persistence/issues/388 as well.

If anyone wants to create a Platform TCK pull request to address the four Servlet TCK challenges, please create a pull request similar to https://github.com/jakartaee/platform-tck/pull/1142 (except the Servlet TCK version will bump to 6.0.3 and Platform TCK bump to 10.0.2).  The Persistence issue change could be included but that is optional for the pull request as that can be addressed as a separate pr.

Thanks,
Scott

On 12/6/22 8:36 AM, Manfred Riem wrote:

Hi there,

 

I have a TCK challenge for the dispatchAfterCommitTest5.

 

See https://github.com/jakartaee/platform-tck/blob/b23c9554913750a532fd60596b09254a8c7340a0/src/com/sun/ts/tests/servlet/api/jakarta_servlet/dispatchtest/DispatchTestServlet.java#L1087

 

The Piranha project delivers a Servlet container that returns “null” for the ServletContext.getContext(String uripath) which is

allowable as per https://jakarta.ee/specifications/servlet/6.0/apidocs/jakarta.servlet/jakarta/servlet/servletcontext#getContext(java.lang.String)

 

As the test in question assumes that a ServletContext is returned it fails.

 

Filed as https://github.com/jakartaee/servlet/issues/490

 

Thanks!

 

Kind regards,

Manfred Riem



_______________________________________________
servlet-dev mailing list
servlet-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/servlet-dev

Back to the top