Re: [servlet-dev] Applying standard formatting

[arjan tijms <arjan.tijms@xxxxxxxxx>]

Hi,

As mentioned in the PR, a big +1 for cleaning and formatting.

Slightly offtopic, but does anyone know how these inconsistencies came about? Where they "deliberately" introduced, or did it happen when source code was migrated between systems, different kinds of source control, editors, etc. I've seen the same thing in a couple of other specs.

Kind regards,

Arjan

On Wed, Aug 29, 2018 at 1:10 AM Dmitry Kornilov <dmitry.kornilov@xxxxxxxxxx> wrote:

Sounds good! Thanks for volunteering.

— Dmitry

> On 28 Aug 2018, at 19:42, Mark Thomas <markt@xxxxxxxxxx> wrote:
>
> Hi,
>
> While I was working on PR#198 I noticed that the formatting of the
> Servlet API was rather inconsistent. There is a mixture of tabs and
> spaces, very different approaches to the use of new lines, odd
> indentation in places and so on.
>
> Arjan pointed out that there is a EE4J guideline for code style:
> https://github.com/eclipse-ee4j/ee4j/wiki/Code-Conventions
>
> I'd like to propose we adopt this guideline. If there is general
> agreement, I'll volunteer to do the work to reformat the code (OK
> Eclipse is going to do most of the work for me) and provide a PR.
>
> Mark
> _______________________________________________
> servlet-dev mailing list
> servlet-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/servlet-dev

_______________________________________________
servlet-dev mailing list
servlet-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/servlet-dev