[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [sensinact-dev] Process for submitting PRs
|
Beautiful, thank you, Tim!!
Best,
=David
On Thu, Jan 11, 2024, at 14:40, Timothy Ward wrote:
Hi David,
The contribution process we recommend is the relatively common GitHub triangular workflow. You've already taken the correct first steps by forking the repository and creating a branch for you to try making changes on.
Normally the next step would be for you to create an issue against the sensiNact repository outlining the problem/enhancement and why a change is needed. This can usually be quite short, but there may be discussion needed for larger changes or ones that
have an impact on backward compatibility. Depending on the size and scope of your change you may want to start working on a fix yourself immediately. If this is the case then please make sure that:
- You have signed the Eclipse Contributor Agreement (ECA)
- You use the same email address in your git commits as you used to sign the ECA
- You remember to add “Signed-off-by: Mickey Mouse <m.mouse@xxxxxxxxxxx>” to *all* your commit messages (the name and email need to match the ECA)
- If applicable please add “Fixes #12345” in one of the commit messages, referring to the issue number that will be addressed by the commit(s)
Once you are happy with your fix you can create a Pull Request from your fork into the sensinact repo. This should almost always be into the master branch, and only somewhere else if requested by a committer. If the changes need to go elsewhere then one
of the committers can usually update the pull request, or cherry pick the commits after merging them into master.
This workflow is available to anyone who wants to contribute to sensiNact. Those with a history of regular contributions may be invited to become committers. As a committer you gain the ability to merge pull requests, and also to push branches directly
into the sensinact repository. This can allow you to avoid working across forks, but committers are still strongly discouraged from pushing directly to the master branch.
I hope this helps to clarify how we try to manage things in sensiNact. Thank you for your question, and I look forward to seeing your contributions.
All the best,
Tim
Sent from my iPhone
On 11 Jan 2024, at 15:39, David Leangen (OSGi) via sensinact-dev <sensinact-dev@xxxxxxxxxxx> wrote:
Hi!
What is the process for submitting a PR?
I created my own local branch on my fork: dml/spifly-update.
To which branch in the main repo should I submit the PR? The same dml/spifly-update? Or directly to master? Or something else?
Thanks!
=David
_______________________________________________
sensinact-dev mailing list
sensinact-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/sensinact-dev
