Hi Olav,
please open a bug report, reference this in you commit, and
send the link to the mailing list.
Interested people will then continue the discussion on that
bug instead of discussion this with the whole mailing list.
Thanks,
Marcel
Marcel Bruch wrote:
This discussion is hard to follow without discussing this line by line in code.
The change generally sounds reasonable to me but I’d like to remind you that breaking APIs is something we shouldn’t take lightly.
Is the current solution working? Does this change have to go in for next Tuesday?
It certainly doesn't have to go into the Tuesday release, i.e., version
2.0.2. It does, however, improve the structure of the code (less
duplication, less propagating of changes that's easy to get wrong), so I
would like to have it for 2.0.3.
As for breaking APIs: all classes we are talking about live in
org.eclipse.recommenders.*internal*.models.rcp, so I wouldn't feel too
bad about breaking things. Even so, the change would not so much affect
the API of ProjectCoordinateProvider and ProjectCoordinateAdvisorService
as it would affect the division of labour between the classes. So, I
would argue (unless we decide to rename a class) that the chances of
breaking clients are slim.
@Olav: Can you draft this change so that we can discuss this "line by line"?
Best wishes,
Andreas
_______________________________________________
recommenders-dev mailing list
recommenders-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/recommenders-dev
_______________________________________________
recommenders-dev mailing list
recommenders-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/recommenders-dev
|
