Re: [rdf4j-dev] Extended branch protections

[Håvard Ottestad <hmottestad@xxxxxxxxx>]

Hi,

I recently pushed to master to fix a flaky test. I really like being able to push to master and develop directly.

That said I agree that this is a good thing, since I think it’s better to move slow and not break things than to move fast and mess if up for everyone else.

Cheers,

Håvard

On 14 Sep 2020, at 06:03, Jeen Broekstra <jeen@xxxxxxxxxxxx> wrote:

hi folks,

I recently pushed a fix directly to master, by accident. Although no real harm was done, it's bad practice, and it got me thinking that we should have some protection against that sort of thing in place. 

To that end, I've asked the Eclipse admins to slightly tighten our branch protections on both master and develop. It is now (or at least, as soon as they've tweaked our config for us) required that the build succeeds before a PR can be merged. This also automatically ensures that no-one can push directly to master or develop: you _have_ to use a feature branch and create PR.

Note that I've deliberately not enabled the ECA check, or requiring review approval, as the first sometimes just gets it wrong, and the second is often hard to obtain in time with not all of us able to review PRs on a daily basis. 

Cheers,

Jeen 

_______________________________________________
rdf4j-dev mailing list
rdf4j-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/rdf4j-dev