Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [rdf4j-dev] SPIN SAIL

Thanks Jerven,

Will update that to volatile. 

Håvard

> On 11 Mar 2019, at 14:24, Jerven Bolleman <jerven.bolleman@sib.swiss> wrote:
> 
> Hi Håvard,
> 
> I can't remember working much on it.
> As I am in the office I can't comment in the github
> but the variable.
> 
> private boolean initializing;
> 
> needs to be volatile if you want the check to be
> correct JMM wise.
> 
> I did not contribute enough to say if this can or can not be skipped.
> 
> I think the idea is to make sure you start with a clean state constraint wise.
> 
> Regards,
> Jerven
> 
>> On 3/11/19 1:58 PM, Håvard Ottestad wrote:
>> Didn’t know about the bitbucket.
>> Thanks Bart. I’ve made a comment on my PR, hope to hear something: https://github.com/eclipse/rdf4j-storage/pull/192
>> Håvard
>>> On 11 Mar 2019, at 12:58, Bart Hanssens (BOSA) <bart.hanssens@xxxxxxxxxxxx <mailto:bart.hanssens@xxxxxxxxxxxx>> wrote:
>>> Hi,
>>> 
>>> Going through the bitbucket Sesame archive, it seems that Dale Visser started the SPIN implementation.
>>> Jerven Bolleman, Jeen, Mark Hale... also worked on it, so maybe they could take a look at the PRs
>>> 
>>> Best regards
>>> 
>>> Bart
>>> 
>>> -----Original Message-----
>>> From: rdf4j-dev-bounces@xxxxxxxxxxx <mailto:rdf4j-dev-bounces@xxxxxxxxxxx> <rdf4j-dev-bounces@xxxxxxxxxxx <mailto:rdf4j-dev-bounces@xxxxxxxxxxx>> On Behalf Of Håvard Ottestad
>>> Sent: maandag 11 maart 2019 12:32
>>> To: rdf4j-dev@xxxxxxxxxxx <mailto:rdf4j-dev@xxxxxxxxxxx>
>>> Subject: [rdf4j-dev] SPIN SAIL
>>> 
>>> Hi,
>>> 
>>> I’m currently working on performance fixes for the spin sail. It takes 700 ms to initialize on my laptop, and I’ve gotten it down to 150 ms. Some fixes for slow code and also by skipping validation during initialization.
>>> 
>>> I tried to look at the history of the SpinSail to see if I could find out who wrote it, but I didn’t have much luck.
>>> 
>>> Does anyone know who wrote it? Or who would know enough about the implementation to check my PR and answer some questions?
>>> 
>>> Cheers,
>>> Håvard
>>> _______________________________________________
>>> rdf4j-dev mailing list
>>> rdf4j-dev@xxxxxxxxxxx <mailto:rdf4j-dev@xxxxxxxxxxx>
>>> To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/rdf4j-dev
>>> _______________________________________________
>>> rdf4j-dev mailing list
>>> rdf4j-dev@xxxxxxxxxxx <mailto:rdf4j-dev@xxxxxxxxxxx>
>>> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
>>> https://www.eclipse.org/mailman/listinfo/rdf4j-dev
>> _______________________________________________
>> rdf4j-dev mailing list
>> rdf4j-dev@xxxxxxxxxxx
>> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
>> https://www.eclipse.org/mailman/listinfo/rdf4j-dev
> 
> _______________________________________________
> rdf4j-dev mailing list
> rdf4j-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://www.eclipse.org/mailman/listinfo/rdf4j-dev


Back to the top