Re: [qvtd-dev] Slow down

[Ed Willink <ed@xxxxxxxxxxxxx>]

Hi

The intention was that the call 'add'ed all the bound variables to the nested environment, then the loops 'replace'd with the prevailing iteration value. If you really don't have control you can just 'replace' anyway.

I needed to add safeVisit to the QVTiEvaluationVisitor interface to avoid CCEs. At that point it gives the same utility as if it were in the Visitor interface. You can also have a protected  overloading undecoratedVisitor2 to avoid the getUndecoratedVisitor() calls and casts.

I need to see a sequence diagram to understand why the loop should be in the visitor interface.

    Regards

        Ed

 


On 04/06/2013 10:32, Horacio Hoyos Rodriguez wrote:

Hi Ed,

Finding the root of the IAE is in my to-do list. I think it has to do something with the nested evaluation environment being reused somehow or not being nested correctly. 

The retiming of the creation of the nested evaluation visitor was needed to make the safeVisit work with the current visitor implementation, but as you say I think that we should leave it as it simplifies the recursive loop in mapping calls. If the doLoop could somehow be added to the QVTi evaluation interface we could have access the the recursive call through the decorated visitor.

Regards, 

_______________________________________________
qvtd-dev mailing list
qvtd-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/qvtd-dev

No virus found in this message.
Checked by AVG - www.avg.com
Version: 2013.0.3343 / Virus Database: 3184/6381 - Release Date: 06/03/13