On Jul 22, 2010, at 1:16 AM, Roland Schulz wrote:
> Hi,
>
> according to
http://wiki.eclipse.org/PTP/developer_guidelines the members should be sorted but often they are not. Thus if people clean-up the code before submitting a patch or committing code, than the patch/commit is significant larger than the change itself. This makes reviewing the change much more difficult than it should be.
>
> Thus I suggest to clean-up the whole code in one go. And in case it is decided that currently is not a good moment to do this change, I would suggest temporarily remove the recommendation to sort-members of existing function until this change is made at a later point.
>
> It might be sufficient to only do the member sorting in one go. Other clean-up changes have less of an effect on the readability of patches. But
> I would suggest to also do the other clean-up changes in the same step.
>
> In this context, I would like to clarify what the recommended setting for formatter and clean-up are. Do we use 80 or 132 line-length?
> Greg asked me to use 132 in 315713 but I'm not sure whether it was meant only in that context or whether this is in general the recommendation.
>
> For the clean-up I use the default of:
> Change non static accesses to static members using declaring type
> Change indirect accesses to static members to direct accesses (accesses through subtypes)
> Remove unused imports
> Add missing '@Override' annotations
> Add missing '@Deprecated' annotations
> Remove unnecessary casts
> Remove unnecessary '$NON-NLS$' tags
> WITHOUT:
> Sort members excluding fields, enum constants, and initializers
> PLUS:
> Organize imports
> Format source code
> Remove trailing white spaces on all lines
> Correct indentation
>
> It this the recommended setting?
>
> I have attached the xml with the formatter and clean-up settings as described here in the text.
>
>
> Roland
>
>
> --
> ORNL/UT Center for Molecular Biophysics
cmb.ornl.gov
> 865-241-1537, ORNL PO BOX 2008 MS6309
