| Dave,
I agree, we should hold off these changes until after the release. Perhaps for the moment you could document the places you think the code should change?
Thanks, Greg
On Jun 5, 2010, at 7:55 PM, Dave Wootton wrote:
Greg
Now that I've resolved my 'invalid
state exception' problem, I'm looking at the changes required for
rate limiting, changing calls to Display.asyncExec to Display.syncExec
where the call is in the path of an event coming from a proxy. I
noticed a couple places where it seems reasonable to change a public method
name, specifically org.eclipse.ptp.ui.UIUtils.safeRunAsyncInUIThread and
org.eclipse.ptp.ui.views.AbstractParallelElementView.asyncExec where I
think that I want to change the method names to safeRunSyncInUIThread and
syncExec, respectively since I plan to change the Display.asyncExec invocation
in each to Display.syncExec.
How should I handle this? It seems pretty
risky to actually change the code to call Display.syncExec at this late
point in the release cycle. Do I change anything at this point? Do I just
change the method names, with a comment explaining the change, and leave
the code alone, even though the method names are misleading, or just leave
these two method names alone?
Dave_______________________________________________
ptp-dev mailing list
ptp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ptp-dev
|
