[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
Re: [ptp-dev] Adding/replacing environment variables on remote processes
|
Creates a new environment tab inheritting from org.eclipse.debug.ui.EnvironmentTab, disable the "append" radio button on tab.
Join this tab into org.eclipse.ptp.launch.parallelLaunchConfigurationTabGroup, instead of use EnvironmentTab directly. Then by no means user can choose to append local environments with remote ones.
Best Regards,
------
Hongchang Lin
Greg Watson <g.watson@xxxxxxxxxxxx>
Greg Watson <g.watson@xxxxxxxxxxxx>
Sent by: ptp-dev-bounces@xxxxxxxxxxx
08/21/2008 01:13 AM
Please respond to
Parallel Tools Platform general developers <ptp-dev@xxxxxxxxxxx> |
|
|
Daniel,
As we discussed, I think the issue of replacing the remote environment
is going to be problematic because it is difficult to achieve on some
ssh implementations. I would suggest disabling this option for remote
connections.
Greg
On Aug 20, 2008, at 8:47 AM, Daniel Felix Ferber wrote:
> Hi,
>
> While I was investigating bug #239251, I see that the parallel
> launcher creates environment variables that inherit on the local
> environment if the "append" option is enabled in the launcher tab.
> This does probably not make sense if the process is running on a
> remote host.
>
> In order to address this issue, I am considering following fixes,
> and would like your feedback before going on with changes.
>
> 1) The
> AbstractParallelLaunchConfigurationDelegate
> .getAttributeManager(...), instead of calling
> DebugPlugin
> .getDefault().getLaunchManager().getEnvironment(configuration),
> creates the array of environment variables by itself. In case of
> "appending" the environment, queries the IRemoteConnection for
> default environment variables of the remote host, that are then
> added to the array.
>
> This means changing the IRemoteConnection interface to support this
> quey. I wonder if this is the right place for the new method. Also,
> implementors of IRemoteProcess must ensure that they do not inherit
> the remote environment (as RemoteTools currently does).
>
> 2) Change the interface of IRemoteProcessBuilder to add a method
> that enables/disables inheriting remote environment. The launcher
> would the use a new JobAttribute to signal to the RuntimeSystem if
> the new Job should "append" or "replace" environment variables on
> the remote host.
>
> Best regards,
> Daniel Felix Ferber
> _______________________________________________
> ptp-dev mailing list
> ptp-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/ptp-dev
>
_______________________________________________
ptp-dev mailing list
ptp-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/ptp-dev


