Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
RE: [platform-vcm-dev] Question regarding file modification behav iour ...

I guess if I answered "No, I don't want to edit it" by mistake, I'll need a
way to make it fire again so I can get the chance to say "Yes".   To tell
you the truth, we are in the middle of getting the milestone release out
and I don't recall what we decided to do here; it may have been to keep
firing it until the file became writeable.  Will investigate.

One case we intend to watch for is the editor regaining focus, since the
read-only state of the file (and contents) may have changed while the user
was away doing other operations in the workbench.

Kevin




                                                                                                                       
                      "Clemm, Geoff"                                                                                   
                      <gclemm@xxxxxxxxxxxx>           To:      platform-vcm-dev@xxxxxxxxxxx                            
                      Sent by:                        cc:                                                              
                      platform-vcm-dev-admin@         Subject: RE: [platform-vcm-dev] Question regarding file          
                      eclipse.org                     modification behav   iour ...                                    
                                                                                                                       
                                                                                                                       
                      03/21/2002 08:34 AM                                                                              
                      Please respond to                                                                                
                      platform-vcm-dev                                                                                 
                                                                                                                       
                                                                                                                       



I would suggest that when you display the MessageDialog,
you should also flush the character input buffer to avoid
this misinterpretation of what the user typed.

But I agree that it is a bug if you do not get another
validateEdit call on subsequent attempts to write to the
(still read-only) file.  One possibility is that the
characters are not being made available as input to the
editor (i.e. when your MessageDialog finished, the input
stream did not end up back in the editor).

Cheers,
Geoff

-----Original Message-----
From: Boris Pruessmann
[mailto:boris+mailinglists.platform-vcm-dev@xxxxxxxxxxxxxx]
Sent: Thursday, March 21, 2002 8:19 AM
To: platform-vcm-dev@xxxxxxxxxxx
Subject: [platform-vcm-dev] Question regarding file modification
behaviour ...



When trying to edit a file that is under control of a team provider we
get informed by IFileModificationValidator.validateEdit. Now, in our
scenario, the follwoing happens:

- We display a MessageDialog, asking the user whether he wants to open
  the file for edit or not.

- The user which already started to type some code presses the 'n' key
  during his typing.

- The dialog closes, the file stays in read-only state. If the user
  continues typing, nothing more happens.

Suggestion:

Although validateEdit returned an IStatus != IStatus.OK, the system should
ask validateEdit on consecutive key typings.

--
"Engineering does not require science. Science helps a lot but
people built perfectly good brick walls long before they knew why
cement works." - Alan Cox


_______________________________________________
platform-vcm-dev mailing list
platform-vcm-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/platform-vcm-dev
_______________________________________________
platform-vcm-dev mailing list
platform-vcm-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/platform-vcm-dev






Back to the top