[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [platform-ui-dev] [eclipse-pmc] Request PMC approval for removal of (transitively) public method in InlineAnnotationSupprot
- From: Lars Vogel <lars.vogel@xxxxxxxxxxx>
- Date: Mon, 19 Mar 2018 11:26:01 +0100
- Delivered-to: email@example.com
+1 from me for cleaning up the LineSpacingProvider API before our 4.8 release.
On Mon, Mar 19, 2018 at 10:59 AM, Mickael Istria <mistria@xxxxxxxxxx> wrote:
> Dear PMC,
> With https://bugs.eclipse.org/bugs/show_bug.cgi?id=532130 , we'd like to
> simplify and improve how iniline annotations/code minings are drawn by
> moving away from LineSpacingProvider.
> I did merge the related patch doing so
> , but then API Tools reported that this was introducing an API breakage:
> . API Tools is obviously right here and Dani noticed it promptly and already
> reverted the patch.
> The initial issue comes from earlier implementation that exposed the
> getLineSpacing method as an inherited public member instead of using
> composition to hiding it. This method was introduced in M5. Although it
> wasn't annotated as @noreference and public, this method was never meant to
> be part of the API and we are not aware of anyone who's referencing it from
> InlineAnnotationSupport nor of any use case for which anyone would want to
> use it. So we feel confident that it's a safe thing to get rid of it now.
> PMC, please evaluate whether changing this API is acceptable at this point
> and mention ASAP if and when we can re-apply the suggested patch.
> Thanks in advance
> Mickael Istria
> Eclipse IDE developer, at Red Hat Developers community
> Elected Committer Representative at the Eclipse Foundation board of
> eclipse-pmc mailing list
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
Eclipse Platform project co-lead
CEO vogella GmbH
Haindaalwisch 17a, 22395 Hamburg
Amtsgericht Hamburg: HRB 127058
GeschÃftsfÃhrer: Lars Vogel, Jennifer Nerlich de Vogel
Fax (040) 5247 6322, Email: lars.vogel@xxxxxxxxxxx, Web: http://www.vogella.com