Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
RE: [platform-ui-dev] Formatting

Another item that may affect this discussion is the bug recently being discussed in the newsgroups - code format on save:
 https://bugs.eclipse.org/bugs/show_bug.cgi?id=22742
 
I know in the teams at my office it is easy to forget to do sort, format, and import often to keep the source differences minimal. If there was an option to perform any/all of these common 'maintenance' operations on save it would make the 'one pass to clean it all up' unneccessary.
 
R.J.


From: platform-ui-dev-admin@xxxxxxxxxxx [mailto:platform-ui-dev-admin@xxxxxxxxxxx] On Behalf Of Randy Hudson
Sent: Wednesday, October 13, 2004 3:46 PM
To: platform-ui-dev@xxxxxxxxxxx
Subject: Re: [platform-ui-dev] Formatting


Ignore white space should solve problem 3.  The exception being Javadoc wrapping if enabled.



Douglas Pollock <douglas.pollock@xxxxxxxx>
Sent by: platform-ui-dev-admin@xxxxxxxxxxx

10/13/2004 04:17 PM

Please respond to
platform-ui-dev

To
platform-ui-dev@xxxxxxxxxxx
cc
Subject
Re: [platform-ui-dev] Formatting





On October 13, 2004 12:44 pm, Stefan Xenos wrote:
> The formatting is causing the following problems:

While formatting does causes problems, there are usually ways around them.


> 1. It is hard to get patches working between branches.

There is the trick of formatting both the maintenance and development stream.  
This means that the only diff between the branches will be functional, not
cosmetic.


> 2. The CVS annotation view has become useless -- it always shows the last
> person to format the file, not the last person to actually change some
> line.

This also applies to files that are moved or to other forms of refactoring.  
The best way to track this down is a binary search of the CVS revision
history -- looking for when a particular change occurred.  

In the case of moved files, this is slightly harder.  You can still do it by
looking for changes that occured at the same time as a file
deletion/addition.

To track changes across a move combined with a functional change, you're
probably forced to use diff from the command-line.


> 3. It is hard to track what was actually changed in a particular checkin,
> since the formatter causes changes throughout the file.

This is unfortunate.  People should try to only commit format changes to CVS
separately from a functional change, if they should do it all....


> 4. It is very hard to compare revisions.

See #1 and #2.



cheers,
d.
_______________________________________________
platform-ui-dev mailing list
platform-ui-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/platform-ui-dev


Back to the top