Re: [platform-ui-dev] Memento tags/types

[Eduardo_Pereira@xxxxxxx]

We tried to centralize all TAGs in IWorkbenchConstants which is ui-internal.
We should not have any hardcoded tags. Ie, "perspHistory" should be changed.

If you see Workbench.java (which I would guess is the file you are changing/fixing) it has
a lot of other TAGs that are in IWorkbenchConstants.

PS: Please once the MRU list is fixed, can you try/test the Switch To Editor as well. 
They use the same history so it should work the same.

Eduardo.

knut_radloff@xxxxxxx Sent by: platform-ui-dev-admin@xxxxxxxxxxx 02/05/2002 03:47 PM Please respond to platform-ui-dev

To:        platform-ui-dev@xxxxxxxxxxx         cc:                 Subject:        [platform-ui-dev] Memento tags/types

What's the policy for adding new memento tags? Should I keep them private 
or add them to IWorkbenchConstants?
I've seen both being done. E.g., TAG_EDITOR_REUSE_THRESHOLD, which seems 
very specialized and will likely not be used by anyone else, is in 
IWorkbenchConstants. "perspHistory" is hardcoded in Workbench.java.
I have two new tags that I use for fixing http://bugs.eclipse.org/bugs/show_bug.cgi?id=2120, "mruList" and 
"persistable".

Knut
_______________________________________________
platform-ui-dev mailing list
platform-ui-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/platform-ui-dev