Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [platform-text-dev] [platform-ui-dev] [proposal] Unite platform text and UI projects forces

Hi Pascal,

the content type patch was merged by Brian and I I think it save to
say that Brian is our most experienced developer in platform ui.  See
https://git.eclipse.org/r/#/c/54257/. So I think your argument is
invalid for content type.

Best regards, Lars

On Sun, Oct 11, 2015 at 3:14 AM, Pascal Rapicault <pascal@xxxxxxxxxxxx> wrote:
> Seeing what happened with the recent changes in the content type bundle,
> where patches have been integrated w/o much background is just worrisome to
> me.
>
> What we are talking is roughly the same, giving commit rights to people with
> no history or no background on the project just so patches can be integrated
> faster, and is a big -1 for me.
>
>
>
> On 15-10-09 08:09 AM, Daniel Megert wrote:
>
> Hi Andrey
>
> I know your patch is waiting, sorry, it's on my list to be done after the
> zoom patch.
>
> -1 from me for the merge. I haven't seen many Text related contributions
> form Platform UI committers that would justify giving access to all Platform
> UI committers. Changes that are of Text context-free related changes (remove
> comments, change BREE, etc.) are not Platform Text specific. Having said
> that, if there are Platform UI committers - or any other contributors - that
> provide further contributions, or good code reviews over the next time, then
> I'd be very happy to welcome them as new committers on Platform Text.
>
> Dani
>
>
>
> From:        Andrey Loskutov <loskutov@xxxxxx>
> To:        platform-text-dev@xxxxxxxxxxx, platform-ui-dev@xxxxxxxxxxx
> Date:        09.10.2015 13:56
> Subject:        [platform-ui-dev] [proposal] Unite platform text and UI
> projects        forces
> Sent by:        platform-ui-dev-bounces@xxxxxxxxxxx
> ________________________________
>
>
>
> Hi all,
>
> Recently I was trying to update the platform text projects to BREE 1.7
> to get rid of nasty compile problems with incompatible JRE (platform
> text still insists to see JRE 1.4 on classpath), see [1], but so far it
> didn't found any feedback except the one non-text committer (it was Lars
> as usually :-)).
>
> This does not surprise me, especially looking on the project statistics
> [2] where one can see that there are actually only 2 active committers
> with commit rights on the platform text (Dani and Markus), and the 2
> commits which were made from non-project contributors are representing
> 9% of the project activity in the last 3 months! BTW both those
> "external" 2 commits were made by platform UI committers.
>
> So while we all know how overloaded both active platform text committers
> are, and how bad our overall state with reviewing bugs and patches etc
> is, why not unite our forces and integrate platform text into platform
> UI project? Those two projects have really many things in common and it
> feels naturally for me if we could allow both teams to work on their
> code together. Actually the half of platform text committers are already
> platform UI committers, but unfortunately not other way around.
>
> So what do you think?
> Does this proposal makes sense for you?
>
> Are platform UI committer ready to take over few projects from platform
> text? Are platform text committers agree to give platform UI members
> commit rights on platform text and vice versa?
>
> Few data about projects in platform text: 6 projects (without tests),
> ~1200 files, 4 committers (2 active):
>
> org.eclipse.core.filebuffers
> org.eclipse.jface.text
> org.eclipse.search
> org.eclipse.text
> org.eclipse.ui.editors
> org.eclipse.ui.workbench.texteditor
>
> For comparison: Platform UI: 38 projects (without tests), ~5200 files,
> 25 committers (although I guess only half of them are active).
>
> [1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=478673
> [2] https://projects.eclipse.org/projects/eclipse.platform.text/who
>
> --
> Kind regards,
> Andrey Loskutov
>
> http://google.com/+AndreyLoskutov
> _______________________________________________
> platform-ui-dev mailing list
> platform-ui-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://dev.eclipse.org/mailman/listinfo/platform-ui-dev
>
>
>
>
> _______________________________________________
> platform-text-dev mailing list
> platform-text-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://dev.eclipse.org/mailman/listinfo/platform-text-dev
>
>
>
> _______________________________________________
> platform-text-dev mailing list
> platform-text-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://dev.eclipse.org/mailman/listinfo/platform-text-dev



-- 
Eclipse Platform UI and e4 project co-lead
CEO vogella GmbH

Haindaalwisch 17a, 22395 Hamburg
Amtsgericht Hamburg: HRB 127058
Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
USt-IdNr.: DE284122352
Fax (032) 221739404, Email: lars.vogel@xxxxxxxxxxx, Web: http://www.vogella.com


Back to the top