[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
RE: [platform-swt-dev] Patch submission for bug #19825
|
McQ,
After your comment about doing
whatever the platform widgets do, I wonder if we talking about the same
thing. It seems you are referring to SWT's text widget, and I'm talking
about Eclipse's text editor. I say this because it doesn't make sense for
the text editor to "follow platform behavior." If this were to be
followed, we would have to remove indent/unindent, scrolling without moving the
caret position (Ctrl+Up/Down), and syntax highlighting (among others), because
the platform (Windows, anyway) doesn't do those either. For the record, I
do believe it is reasonable and valid for the text *widget* to follow the
platform behavior.
Ron
Pasted into the PR
system:
"right click outside
existing selection, doesn't remove selection or move caret:"
As far as I can see, this
*is* the current behavior of the widget, and for the record, *we* like it that
way, since it's the way every IDE we've ever built (i.e. VA/ME 1.0, VA/Java,
VA/Smalltalk, ...) works.
Separate
from that however, SWT ought to do whatever the platform widgets do. If native
text widgets, used in the canonical way do not move the selection, then SWT
should not.
However, there is a
consistancy argument in favor of Ron's view _at_the_Eclipse_UI_ level: Eclipse
implements "right click selects before popping up the menu" behavior in Trees.
It would seem that we should do the closest "typical" behavior in the text
widgets as well (which is the behavior Ron wants). This is a UI TEAM decision,
and as such they were in error to send you back to the SWT team.
McQ.
| Ron Baldwin
<ron.baldwin@xxxxxxxxxxxxxxx> Sent by: platform-swt-dev-admin@xxxxxxxxxxx
30/01/03 16:47 Please respond to platform-swt-dev
| To:
"'platform-swt-dev@xxxxxxxxxxx'"
<platform-swt-dev@xxxxxxxxxxx> cc:
Subject: RE: [platform-swt-dev] Patch
submission for bug #19825 |
Veronika, the patch is against StyledText, so the text guys sent me
back
here.
So, back to the patch... McQ posted an objection to
the bug report
(#19825), but I'm not sure what he means. I would like
to resolve the
objection and get the change in before M5 if possible.
If it comes down to
personal taste, what about adding a
preference?
Ron
> -----Original Message-----
> From:
Veronika_Irvine@xxxxxxxxxx [mailto:Veronika_Irvine@xxxxxxxxxx]
> Sent:
Monday, January 27, 2003 9:03 AM
> To:
platform-swt-dev@xxxxxxxxxxx
> Subject: Re: [platform-swt-dev] Patch
submission for bug #19825
>
>
> Your bug report is against
Platform Text so this isn't really the
> newsgroup to discuss
this.
>
> I think you would get the most immediate response if
you put
> your question
> in the bug report.
>
>
>
>
>
> Ron Baldwin
<ron.baldwin@xxxxxxxxxxxxxxx>
> Sent by:
platform-swt-dev-admin@xxxxxxxxxxx
> 01/27/2003 12:43 AM
> Please
respond to platform-swt-dev
>
>
>
To: "'platform-swt-dev@xxxxxxxxxxx'"
>
<platform-swt-dev@xxxxxxxxxxx>
> cc:
> Subject:
[platform-swt-dev] Patch submission
> for bug #19825
>
>
>
> Hi all,
>
> I have submitted a patch
for bug #19825, and attached it to the bug
> report.
> As this is
my first patch submission, I have a couple of questions:
>
> 1.
How long does it usually take (assuming the patch is
> acceptable) to
get
> it committed to CVS?
> 2. Is there enough time for it to
make it into M5? (hint:
> correct answer
> is
> yes :-)
)
>
> Ron
>
>
_______________________________________________
> platform-swt-dev
mailing list
> platform-swt-dev@xxxxxxxxxxx
>
http://dev.eclipse.org/mailman/listinfo/platform-swt-dev
>
>
>
> _______________________________________________
>
platform-swt-dev mailing list
> platform-swt-dev@xxxxxxxxxxx
>
http://dev.eclipse.org/mailman/listinfo/platform-swt-dev
>
_______________________________________________
platform-swt-dev
mailing
list
platform-swt-dev@xxxxxxxxxxx
http://dev.eclipse.org/mailman/listinfo/platform-swt-dev