[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: Fw: [platform-releng-dev] [eclipse-build]Build I20090324-1325 (Timestamp: 200903241325):Automated JUnit testing complete. Test failures/errors occurred.
|
>Today this happens by virtue of the junit tests failing, and I do agree
with Dani that this is not the most efficient way to surface the problem.
Yes, we were lucky to load those classes (not every class is covered by a
test).
>I think the change that is most realistic in a 3.5 time frame is to have
the comparison results surfaced, if not as build errors, at least as a log
that we can look at when junits failed.
I disagree. For 3.5 we should make sure that bundles with compile errors
are not published to the p2 repo (see bug
https://bugs.eclipse.org/bugs/show_bug.cgi?id=269972).
Dani
|------------>
| From: |
|------------>
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|Andrew Niefer <aniefer@xxxxxxxxxx> |
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|------------>
| To: |
|------------>
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|"Eclipse platform release engineering list." <platform-releng-dev@xxxxxxxxxxx> |
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|------------>
| Date: |
|------------>
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|25.03.2009 19:41 |
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|------------>
| Subject: |
|------------>
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|Re: Fw: [platform-releng-dev] [eclipse-build]Build I20090324-1325 (Timestamp: 200903241325):Automated JUnit testing complete. Test |
|failures/errors occurred. |
>--------------------------------------------------------------------------------------------------------------------------------------------------|
I'm a little late on this thread because of EclipseCon, but thought I would
comment because I'm actually giving a short talk on this topic later today.
> OK, I think I found the problem: when PDE fixed their contribution they
> only retagged the pde.core bundle which they missed previously. Now, it
> looks like all source of the build is checked out from the CVS repository
> and compiled and hence no compile errors get reported during the build.
> However, when the build is assembled p2 (repo) is used and the old pde.ui
> bundle gets used as the version did no change.
This is correct. We have to remember that people are not just runnig the
zips. They are running previous builds and updating only the things that
had versions changed.
The problem is this: The binary bits changed. The source did not change
and the version did not change. The fundamental assumption we are working
with is that 1 version == 1 set of bits.
We can't ship the new bits under the old version. because then you have
different users running different things dependening on how they got their
bits.
So we need the build to tell us when we hit this problem. Today this
happens by virtue of the junit tests failing, and I do agree with Dani that
this is not the most efficient way to surface the problem.
As Kim mentioned, we do run a comparison between the original version and
the newly compiled bits (thanks to Olivier for this code). There is still
some work to get the results of this comparison surfaced as build
errors/warnings telling us that something has changed and the bundles need
to be retagged/upversioned.
I think the change that is most realistic in a 3.5 time frame is to have
the comparison results surfaced, if not as build errors, at least as a log
that we can look at when junits failed.
-Andrew
Daniel Megert
<daniel_megert@xxxxxx.c
om> To
Sent by: "Eclipse platform release engineering
platform-releng-dev-bou list." <platform-releng-dev@xxxxxxxxxxx>
nces@xxxxxxxxxxx cc
Subject
03/25/2009 03:15 AM Fw: [platform-releng-dev]
[eclipse-build]Build I20090324-1325
(Timestamp: 200903241325):Automated
Please respond to JUnit testing complete. Test
"Eclipse platform failures/errors occurred.
release engineering
list."
<platform-releng-dev@e
clipse.org>
OK, I think I found the problem: when PDE fixed their contribution they
only retagged the pde.core bundle which they missed previously. Now, it
looks like all source of the build is checked out from the CVS repository
and compiled and hence no compile errors get reported during the build.
However, when the build is assembled p2 (repo) is used and the old pde.ui
bundle gets used as the version did no change.
If this is correct then we urgently need to fix the build process so that
the source used to compile and the bits used to assemble the build are the
same. Otherwise the result is doomed as the latest test failures show.
Dani
----- Forwarded by Daniel Megert/Zurich/IBM on 25.03.2009 11:07 -----.
|------------>
| From: |
|------------>
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|Daniel Megert/Zurich/IBM
|
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|------------>
| To: |
|------------>
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|"Eclipse platform release engineering list."
<platform-releng-dev@xxxxxxxxxxx>
|
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|------------>
| Date: |
|------------>
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|25.03.2009 10:07
|
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|------------>
| Subject: |
|------------>
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|Re: [platform-releng-dev] [eclipse-build]Build I20090324-1325
(Timestamp: 200903241325):Automated JUnit testing complete. Test
failures/errors|
|occurred.
|
>--------------------------------------------------------------------------------------------------------------------------------------------------|
The JDT UI and LTK failures are caused by compile errors in PDE types. I
would have expected this from the 0800 build but not after PDE corrected
its build input and after seeing no compile errors reported by the build.
Below is the compile error.
Kim, could it be that the results got mingled? They look the same as in the
0800 build where there were indeed PDE compiler errors. Or maybe the PDE
team has a clue what's wrong here.
Dani
Unresolved compilation problems: The import
org.eclipse.pde.internal.core.text.bundle cannot be resolved The method
getBundle(IFile, IProgressMonitor) from the type BundleManifestChange
refers to the missing type Bundle BundleTextChangeListener cannot be
resolved to a type BundleTextChangeListener cannot be resolved to a type
BundleModel cannot be resolved to a type BundleSymbolicNameHeader cannot be
resolved to a type BundleSymbolicNameHeader cannot be resolved to a type
java.lang.Error: Unresolved compilation problems:
The import org.eclipse.pde.internal.core.text.bundle cannot be resolved
The method getBundle(IFile, IProgressMonitor) from the type
BundleManifestChange refers to the missing type Bundle
BundleTextChangeListener cannot be resolved to a type
BundleTextChangeListener cannot be resolved to a type
BundleModel cannot be resolved to a type
BundleSymbolicNameHeader cannot be resolved to a type
BundleSymbolicNameHeader cannot be resolved to a type
at
org.eclipse.pde.internal.ui.refactoring.ContainerRenameParticipant.<init>
(ContainerRenameParticipant.java:25)
at java.lang.reflect.Constructor.newInstance(Constructor.java:494)
at java.lang.Class.newInstance0(Class.java:350)
at java.lang.Class.newInstance(Class.java:303))
at
org.eclipse.core.internal.registry.osgi.RegistryStrategyOSGI.createExecutableExtension
(RegistryStrategyOSGI.java:170)
at
org.eclipse.core.internal.registry.ExtensionRegistry.createExecutableExtension
(ExtensionRegistry.java:874)
at
org.eclipse.core.internal.registry.ConfigurationElement.createExecutableExtension
(ConfigurationElement.java:243):
at
org.eclipse.core.internal.registry.ConfigurationElementHandle.createExecutableExtension
(ConfigurationElementHandle.java:51)
at
org.eclipse.ltk.internal.core.refactoring.ParticipantDescriptor.createParticipant
(ParticipantDescriptor.java:86)
|------------>
| From: |
|------------>
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|eclipse-releng@xxxxxxxxxxx
|
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|------------>
| To: |
|------------>
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|platform-releng-dev@xxxxxxxxxxx
|
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|------------>
| Date: |
|------------>
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|25.03.2009 04:04
|
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|------------>
| Subject: |
|------------>
>--------------------------------------------------------------------------------------------------------------------------------------------------|
|[platform-releng-dev] [eclipse-build]Build I20090324-1325 (Timestamp:
200903241325):Automated JUnit testing complete. Test failures/errors |
|occurred.
|
>--------------------------------------------------------------------------------------------------------------------------------------------------|
Build I20090324-1325 (Timestamp: 200903241325): Automated JUnit testing is
complete. Test failures/errors occurred in the following:
org.eclipse.jdt.ui.tests.refactoring_linux.gtk.x86
org.eclipse.jdt.ui.tests.refactoring_linux.gtk.x86_6.0
org.eclipse.jdt.ui.tests.refactoring_macosx.carbon.ppc_5.0
org.eclipse.jdt.ui.tests.refactoring_win32.win32.x86
org.eclipse.jdt.ui.tests.refactoring_win32.win32.x86_6.0
org.eclipse.ltk.core.refactoring.tests_linux.gtk.x86
org.eclipse.ltk.core.refactoring.tests_linux.gtk.x86_6.0
org.eclipse.ltk.core.refactoring.tests_macosx.carbon.ppc_5.0
org.eclipse.ltk.core.refactoring.tests_win32.win32.x86
org.eclipse.ltk.core.refactoring.tests_win32.win32.x86_6.0
org.eclipse.pde.ui.tests_linux.gtk.x86
org.eclipse.pde.ui.tests_linux.gtk.x86_6.0
org.eclipse.pde.ui.tests_macosx.carbon.ppc_5.0
org.eclipse.pde.ui.tests_win32.win32.x86
org.eclipse.pde.ui.tests_win32.win32.x86_6.0
org.eclipse.releng.tests_win32.win32.x86_6.0
HTTP Download:
http://download.eclipse.org/eclipse/downloads/drops/I20090324-1325
_______________________________________________
platform-releng-dev mailing list
platform-releng-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/platform-releng-dev
_______________________________________________
platform-releng-dev mailing list
platform-releng-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/platform-releng-dev
_______________________________________________
platform-releng-dev mailing list
platform-releng-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/platform-releng-dev
