Re: [platform-releng-dev] [eclipse-build]Build N20061006-0010 (Timestamp

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]

Re: [platform-releng-dev] [eclipse-build]Build N20061006-0010 (Timestamp: 200610060010):Automated JUnit testing complete. Test failures/errors occurred.

From: Steven Wasleski <wasleski@xxxxxxxxxx>
Date: Fri, 6 Oct 2006 12:37:37 -0400
Delivered-to: platform-releng-dev@xxxxxxxxxxx
List-archive: <http://eclipse.org/pipermail/platform-releng-dev>
List-help: <mailto:platform-releng-dev-request@eclipse.org?subject=help>
List-subscribe: <https://dev.eclipse.org/mailman/listinfo/platform-releng-dev>, <mailto:platform-releng-dev-request@eclipse.org?subject=subscribe>
List-unsubscribe: <https://dev.eclipse.org/mailman/listinfo/platform-releng-dev>, <mailto:platform-releng-dev-request@eclipse.org?subject=unsubscribe>

I believe CHKPII complains about \' in a property because using \' often does not give the results the developer intended. I have talked to several developers that think it means that the single quote will end up going through MessageFormat untouched but that is not what happens. What does happen is that as the property is read in and a String object created from it, the \' ends up just being a ' in the String. That is, the escape sequence is interpreted at that time and MessageFormat never sees the escape sequence. It just sees the single quote and treats it as such. Which usually means it is stripped out.

So, the best practice is for messages that will be processed by MessageFormat (or the equivalent org.eclipse.osgi.NLS method) is that if you want a ' in the result, double it in the property. Do not try an escape sequence. If the message will not be processed by MessageFormat the \' buys you nothing over ' and may just cause confusion down the road.

The platform build uses the -jsq option on CHKPII. This tells CHKPII to assume that any message with substitutions will be processed by MessageFormat and any message without substitutions will not (this is our typical usage). It flags things accordingly. If you have a properties file for which all messages go through MessageFormat regardless of substitutions, there is a directive that can be placed in the file to indicate to CHKPII that this is the case. There is also a directive for never goes through MessageFormat and one that is the equivalent of the -jsq option. If your message processing is typical (only go through MessageFormat if there are substitutions), you will not need any of these directives.

Thanks,
Steve Wasleski

IES Technical Lead

Olivier Thomann <Olivier_Thomann@xxxxxxxxxx>

Olivier Thomann <Olivier_Thomann@xxxxxxxxxx>

Sent by: platform-releng-dev-bounces@xxxxxxxxxxx

10/06/2006 11:44 AM

Please respond to
"Eclipse platform release engineering list." <platform-releng-dev@xxxxxxxxxxx>

To	"Eclipse platform release engineering list." <platform-releng-dev@xxxxxxxxxxx>
cc
Subject	Re: [platform-releng-dev] [eclipse-build]Build N20061006-0010 (Timestamp: 200610060010):Automated JUnit testing complete. Test failures/errors occurred.

For all patches, using '' instead of \' doesn't seem to change anything. And chkpii is happy with the double quote. My only concern is the nls message in ant.ui, where I don't really see how to get rid of the error since the message is: InternalAntRunner.1=\t\t\t\t\'\' I tried different options and chkpii still complains. I don't know why it tries to check double single quote in a string that doesn't contain any substitutions. It seems perfectly reasonable to expect two single quotes in an error message. I could not find any clue on the usage of \'. Any thoughts? Olivier Thomas Watson <tjwatson@xxxxxxxxxx> Sent by: platform-releng-dev-bounces@xxxxxxxxxxx 2006-10-06 11:34 Please respond to "Eclipse platform release engineering list." <platform-releng-dev@xxxxxxxxxxx> To "Eclipse platform release engineering list." <platform-releng-dev@xxxxxxxxxxx> cc Subject Re: [platform-releng-dev] [eclipse-build]Build N20061006-0010 (Timestamp: 200610060010):Automated JUnit testing complete. Test failures/errors occurred. Olivier, I assume we should hold off on releasing the fixes to the bugs you opened for the chkpii errors until you can confirm they really do need to be fixed? Tom Olivier Thomann <Olivier_Thomann@xxxxxxxxxx> Sent by: platform-releng-dev-bounces@xxxxxxxxxxx 10/06/2006 09:46 AM Please respond to "Eclipse platform release engineering list." <platform-releng-dev@xxxxxxxxxxx> To "Eclipse platform release engineering list." <platform-releng-dev@xxxxxxxxxxx> cc Subject Re: [platform-releng-dev] [eclipse-build]Build N20061006-0010 (Timestamp: 200610060010):Automated JUnit testing complete. Test failures/errors occurred. This might be the change that reported all the chkpii errors: For Java ResourceBundle files, handle escaped single quotes (\') the same as the single quote character when performing NLS_MESSAGEFORMAT processing. Escaped single quotes are changed to a single quote character before the MessageFormat() class is executed (P028364). This looks suspicious to me. \' is perfectly fine. I'll try to get more info on the usage of \' inside nls message. Olivier Kim Moir/Ottawa/IBM@IBMCA Sent by: platform-releng-dev-bounces@xxxxxxxxxxx 2006-10-06 10:24 Please respond to "Eclipse platform release engineering list." <platform-releng-dev@xxxxxxxxxxx> To "Eclipse platform release engineering list." <platform-releng-dev@xxxxxxxxxxx> cc Subject Re: [platform-releng-dev] [eclipse-build]Build N20061006-0010 (Timestamp: 200610060010):Automated JUnit testing complete. Test failures/errors occurred. Thanks Olivier. Yes, I updated the version of chkpii yesterday. Kim Olivier Thomann/Ottawa/IBM@IBMCA Sent by: platform-releng-dev-bounces@xxxxxxxxxxx 10/06/2006 10:16 AM Please respond to "Eclipse platform release engineering list." <platform-releng-dev@xxxxxxxxxxx> To "Eclipse platform release engineering list." <platform-releng-dev@xxxxxxxxxxx> cc Subject Re: [platform-releng-dev] [eclipse-build]Build N20061006-0010 (Timestamp: 200610060010):Automated JUnit testing complete. Test failures/errors occurred. I opened:https://bugs.eclipse.org/bugs/show_bug.cgi?id=160006 (jdt.debug)https://bugs.eclipse.org/bugs/show_bug.cgi?id=160007 (ant.ui)https://bugs.eclipse.org/bugs/show_bug.cgi?id=160008 (update.core)https://bugs.eclipse.org/bugs/show_bug.cgi?id=160009 (osgi)https://bugs.eclipse.org/bugs/show_bug.cgi?id=160010 (jdt.ui) to track these down. It seems that \' is not accepted anymore by chkpii. Olivier Kim Moir/Ottawa/IBM@IBMCA Sent by: platform-releng-dev-bounces@xxxxxxxxxxx 2006-10-06 08:43 Please respond to "Eclipse platform release engineering list." <platform-releng-dev@xxxxxxxxxxx> To "Eclipse platform release engineering list." <platform-releng-dev@xxxxxxxxxxx> cc Subject Re: [platform-releng-dev] [eclipse-build]Build N20061006-0010 (Timestamp: 200610060010):Automated JUnit testing complete. Test failures/errors occurred. The releng failures are due to chkpii errors inhttp://download.eclipse.org/eclipse/downloads/drops/N20061006-0010/testresults/chkpii/linux.gtk.x86_5.0_org.eclipse.nls.properties.txt org.eclipse.jdt.debug org.eclipse.ant.ui org.eclipse.update.core org.eclipse.osgi Kim eclipse-releng@xxxxxxxxxxx Sent by: platform-releng-dev-bounces@xxxxxxxxxxx 10/06/2006 06:02 AM Please respond to "Eclipse platform release engineering list." <platform-releng-dev@xxxxxxxxxxx> To platform-releng-dev@xxxxxxxxxxx cc Subject [platform-releng-dev] [eclipse-build]Build N20061006-0010 (Timestamp: 200610060010):Automated JUnit testing complete. Test failures/errors occurred. Build N20061006-0010 (Timestamp: 200610060010): Automated JUnit testing is complete. Test failures/errors occurred in the following: org.eclipse.jdt.debug.tests_win32.win32.x86 org.eclipse.jdt.text.tests_linux.gtk.x86 org.eclipse.releng.tests_linux.gtk.x86 org.eclipse.releng.tests_linux.gtk.x86_5.0 org.eclipse.releng.tests_win32.win32.x86 org.eclipse.team.tests.cvs_linux.gtk.x86 org.eclipse.ui.tests_linux.gtk.x86 org.eclipse.ui.tests_linux.gtk.x86_5.0 org.eclipse.ui.tests_macosx.carbon.ppc org.eclipse.ui.tests_win32.win32.x86 HTTP Download:http://download.eclipse.org/eclipse/downloads/drops/N20061006-0010 FTP Download: user: anonymous password: (e-mail address or leave blank) server: download.eclipse.org cd to directory: N20061006-0010 or ftp://download.eclipse.org/N20061006-0010_______________________________________________ platform-releng-dev mailing list platform-releng-dev@xxxxxxxxxxxhttps://dev.eclipse.org/mailman/listinfo/platform-releng-dev_______________________________________________ platform-releng-dev mailing list platform-releng-dev@xxxxxxxxxxxhttps://dev.eclipse.org/mailman/listinfo/platform-releng-dev_______________________________________________ platform-releng-dev mailing list platform-releng-dev@xxxxxxxxxxxhttps://dev.eclipse.org/mailman/listinfo/platform-releng-dev_______________________________________________ platform-releng-dev mailing list platform-releng-dev@xxxxxxxxxxxhttps://dev.eclipse.org/mailman/listinfo/platform-releng-dev_______________________________________________ platform-releng-dev mailing list platform-releng-dev@xxxxxxxxxxxhttps://dev.eclipse.org/mailman/listinfo/platform-releng-dev_______________________________________________ platform-releng-dev mailing list platform-releng-dev@xxxxxxxxxxxhttps://dev.eclipse.org/mailman/listinfo/platform-releng-dev_______________________________________________ platform-releng-dev mailing list platform-releng-dev@xxxxxxxxxxxhttps://dev.eclipse.org/mailman/listinfo/platform-releng-dev

References:
- Re: [platform-releng-dev] [eclipse-build]Build N20061006-0010 (Timestamp: 200610060010):Automated JUnit testing complete. Test failures/errors occurred.
  - From: Olivier Thomann

Breadcrumbs