[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [pdt-dev] Formalize commit / patch description patterns

+1 for "[WIP] Bug 1234 - Description" :)


From: kaloyan.r@xxxxxxxx
Date: Thu, 19 Feb 2015 08:04:10 +0200
To: pdt-dev@xxxxxxxxxxx
Subject: Re: [pdt-dev] Formalize commit / patch description patterns

+1 
I like conventions. I don't have any preference for the WIP.

Kaloyan

On Thu, Feb 19, 2015 at 12:29 AM, Michał Niewrzał <michal.n@xxxxxxxx> wrote:
Hello,
+1 from me:) I prefer version:
[WIP] Bug 1234 - Description 
but it is only matter of taste ;) 

Michal

On Wed, Feb 18, 2015 at 9:10 PM, Dawid Pakuła <zulus@xxxxxxxxx> wrote:
Hi,

I have two proposition for today.

1. Since around year, most (if not all) commit messages follow this pattern at first line:

Bug 12345 / No bug - Short bug description

I propose to make it as a standard and put information about this into our Contribution Guide [1]

2. As you probably noticed, since couple days (weeks) gerrit automatically add patch and commit links to our bugs.

To avoid confusion and questions like "Is this ready to review / IP process?" i have a proposition to add "[WIP]" prefix before bug description:

Bug 1234 - [WIP] Description

Alternative could be:
[WIP] Bug 1234 - Description 

Platform UI standard. But this probably also disable gerrit bot until message update (I'm not sure).

What do you think / prefer

[1] - https://wiki.eclipse.org/PDT/Contributing
--
Dawid Pakuła 

_______________________________________________
pdt-dev mailing list
pdt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/pdt-dev


_______________________________________________
pdt-dev mailing list
pdt-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/pdt-dev


_______________________________________________ pdt-dev mailing list pdt-dev@xxxxxxxxxxx To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/pdt-dev