| Re: [pdt-dev] Old PDT code formatter |
|
Hi Michal,
I don't know much more than you about the "historical info", but I'm also interested in this subject, because I worked (and plan to do more work) on the (new) code formatter. It would be really nice to remove all dead code ;) Thierry. Date: Tue, 13 Jan 2015 13:25:59 +0100 From: michal.n@xxxxxxxx To: pdt-dev@xxxxxxxxxxx Subject: [pdt-dev] Old PDT code formatter Hi,
In need future I want back to my old bug (https://bugs.eclipse.org/bugs/show_bug.cgi?id=438240) about code pasting. I was reviewing code and meaningful for this fix code is strongly related to old code formatter. I found some funny code like this:) final boolean licensed = true; if (licensed) { formatter = new PHPCodeFormatter(); } else { formatter = new MultiPassContentFormatter( IStructuredPartitioning.DEFAULT_STRUCTURED_PARTITIONING, IHTMLPartitions.HTML_DEFAULT); ((MultiPassContentFormatter) formatter) .setMasterStrategy(new StructuredFormattingStrategy( new PhpFormatProcessorImpl())); } Old formatter looks unused and my question is this 100% true? A lot of code can be removed in this case, but maybe someone knows something against this idea:) Thanks for any historical info :) Michal _______________________________________________ pdt-dev mailing list pdt-dev@xxxxxxxxxxx To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/pdt-dev |