Hi Curtis,
I find two places where the slicer is created in the
org.eclipse.pde.internal.core.target.IUBundleContainer.resolveWithSlicer()
function:
if (getIncludeAllEnvironments()) {
slicer = new PermissiveSlicer(allMetadata, new Properties(), true,
false, true, true, false);
} else {
...
slicer = new PermissiveSlicer(allMetadata, props, true, false,
false, true, false);
}
The considerOnlyStrictDependency is the second last argument, i.e. true
in both cases.
Regards,
Thomas Hallgren
On 05/27/2010 10:57 PM, Curtis Windatt wrote:
I can't explain things
very well for you,
Jeff would probably be more knowledgeable about the slicer as he helped
us to set it up.
We use the PermissiveSlicer and...
include optional dependencies = true
everything greedy = false
eval filter to = true
consider only strict dependencies =
false
only filtered requirements = false
Curtis
On 05/27/2010 09:59 PM, Ian Bull wrote:
I don't know for sure, but I think what it's trying to
do is only fetch "includes" vs. "requires". For
example, if feature foo "includes" bundles A,B and C (but requires
D-Z), unchecking this box will only fetch A, B and C (i.e. not
"including
the required software").
I think John helped with this, so he might be the best
person to talk to.
But if a bundle requirement is strict, that
requirement
will also be considered right? And a "requires" using a perfect
match too. Add that some build systems actually generate non strict
ranges
even for "includes" in order to avoid future conflicts and the
whole scheme falls apart.
Using a strict dependency to identify "includes" versus "requires"
just doesn't seem right. It's based on an old concept and makes
assumptions
that are sometimes incorrect.
p2 can prevent that things are installed when they are missing (greedy
= false). Why isn't that used for this purpose? If the publisher
generated
"requires" as greedy=false and if there was a difference in how
"everything greedy" is handled, that would make a lot more sense.
- thomas
cheers,
ian
On Thu, May 27, 2010 at 12:50 PM, Thomas Hallgren <thomas@xxxxxxx>
wrote:
Hi,
I was recently made aware that if I provision a target platform with
"Include
required software" unchecked, the slicer used will only follow consider
requirements with strict version ranges. I fail to see the logic in
that.
Can someone please explain why that is?
Regards,
Thomas Hallgren
_______________________________________________
pde-dev mailing list
pde-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/pde-dev
--
R. Ian Bull | EclipseSource Victoria | +1 250 477 7484
http://eclipsesource.com
| http://twitter.com/eclipsesource
_______________________________________________
pde-dev mailing list
pde-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/pde-dev
_______________________________________________
pde-dev mailing list
pde-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/pde-dev
_______________________________________________
pde-dev mailing list
pde-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/pde-dev
|
