Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [paho-dev] Submiting PR to Paho-C

Ian,

This is certainly up to you. Just be aware it looks like the Paho repo has not been mirrored to github in the last 9 months. I have opened a bug about this. https://bugs.eclipse.org/bugs/show_bug.cgi?id=480459

Ian S


On 23/10/2015 9:01 AM, Ian Craggs wrote:
Yes, but this page:

https://wiki.eclipse.org/Development_Resources/Contributing_via_Git#via_GitHub

on the Eclipse wiki says:

If the project repository is hosted on GitHub, you can issue a standard GitHub pull request. Ensure that you have a CLA and that the commit record is properly "Signed-off-by" before you issue the request.

and the Paho repositories are mirrored on GitHub, so I thought I should learn :-)  "Mirroring" may not be the same as "hosting", but I think the fact that the repositories are accessible from GitHub does set some expectations.  Angelo has signed the CLA and signed the contribution off.

Ian

On 10/23/2015 12:56 PM, Ian Skerrett wrote:
Would it be easier if Angelo just submits his pull request via Gerrit?


Sent from Samsung Mobile


-------- Original message --------
From: Ian Craggs
Date:10-23-2015 06:24 (GMT-05:00)
Subject: Re: [paho-dev] Submiting PR to Paho-C

Hi Angelo,

thanks for the contribution.  I'm not used to accepting pull requests from Github (usually bugzilla or Gerrit) so I'm going to have to work out how to handle it.    I hope to get to it over the weekend.

Ian


On 10/22/2015 08:54 PM, Angelo Ribeiro wrote:
Hi, 

I would like to know if I'm following the right process to contribute back to paho-c. 

I have signed the CLA and have submit a pr on github. 

Here is the PR to add 64 bits (Windows) configuratio on our project files...


Do I have to follow any other process or use other tools to have this accepted? 

I have submit this on October 12th and not answer yet. 

I have another PR (A fix this time), but I would like to check if I'm following the right process. 

Thanks,  
---
Angelo Ribeiro
Msc - Federal University of Pernambuco
Team in Training Alumni Triple Crowned! :)


_______________________________________________
paho-dev mailing list
paho-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/paho-dev

-- 
Ian Craggs                          
icraggs@xxxxxxxxxx                 IBM United Kingdom
Paho Project Lead; Committer on Mosquitto



_______________________________________________
paho-dev mailing list
paho-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/paho-dev

-- 
Ian Craggs                          
icraggs@xxxxxxxxxx                 IBM United Kingdom
Paho Project Lead; Committer on Mosquitto



_______________________________________________
paho-dev mailing list
paho-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/paho-dev

-- 

Ian Skerrett
VP of Marketing
Eclipse Foundation
(m) 613-240-7210
(o) 613-224-9461 ext 227
(t) @ianskerrett

Back to the top