Hello Ed,
thank you for the info. In the Eclipse IDE PDE Launcher I could already admire the hard represented equinox launcher. And because there is no p2.inf in the org.eclipse.equinox.launcher_1.5.800.v20200727-1323.jar
I also suspected that p2 has done a hard representation of the equinox launcher.
The alternative would be to start the launcher with java -jar com.customer.launcher_1.0.0.jar. However, the config.ini will then no longer be considered. But the own launcher could read this by itself.
Have I still missed something?
Many thanks and greetings
Frank
Von: p2-dev-bounces@xxxxxxxxxxx <p2-dev-bounces@xxxxxxxxxxx>
Im Auftrag von Ed Merks
Gesendet: Donnerstag, 26. November 2020 06:19
An: p2-dev@xxxxxxxxxxx
Betreff: Re: [p2-dev] -startup - p2.inf
Frank,
My sense is that these things are hard coded to expect the org.eclipse.equinox.launcher.
https://git.eclipse.org/c/equinox/rt.equinox.p2.git/tree/bundles/org.eclipse.equinox.p2.publisher.eclipse/src/org/eclipse/equinox/p2/publisher/eclipse/EquinoxLauncherCUAction.java#n91
https://git.eclipse.org/c/equinox/rt.equinox.p2.git/tree/bundles/org.eclipse.equinox.p2.publisher.eclipse/src/org/eclipse/equinox/p2/publisher/eclipse/ConfigCUsAction.java#n67
All uses of -startup in my SDK workspace look like the following, i.e., with no hard coding of artifact locations:
addProgramArg(programArg:-startup);addProgramArg(programArg:@artifact);
So I'm doubtful that what you're trying to do is workable.
Regards,
Ed
On 26.11.2020 04:44, Hoelting, Frank wrote:
Hallo,
for a client I developed an Eclipse Launcher that replaces the original one. To use the customer launcher I set the new launcher in the p2.inf as follows.
instructions.unconfigure=\
org.eclipse.equinox.p2.touchpoint.eclipse.removeProgramArg(programArg:-startup);\
org.eclipse.equinox.p2.touchpoint.eclipse.removeProgramArg(programArg:plugins${#47}org.eclipse.equinox.launcher_1.5.800.v20200727-1323.jar);
instructions.configure=\
org.eclipse.equinox.p2.touchpoint.eclipse.addProgramArg(programArg:-startup);\
org.eclipse.equinox.p2.touchpoint.eclipse.addProgramArg(programArg:plugins${#47}com.project.launcher_1.0.0.jar);
the result surprises me after all:
config.ini
-startup
plugins/com.product.launcher_1.0.0.jar
-startup
C:\com.customer\products\com.product\target\products\com.initka.nui.development.product\win32\win32\x86_64\plugins\org.eclipse.equinox.launcher_1.5.800.v20200727-1323.jar
--launcher.library
plugins/org.eclipse.equinox.launcher.win32.win32.x86_64_1.1.1300.v20200819-0940
Instead of deleting the old launcher org.eclipse.equinox.launcher_1.5.800.v20200727-1323.jar it is now generated with an absolute path. Without p2.inf the old launcher is generated correctly.
-startup
plugins\org.eclipse.equinox.launcher_1.5.800.v20200727-1323.jar
How can I replace the old launcher with the new one?
Maven 3.6
Tycho 1.7.0 and 2.1.0
Java 11
Many thanks and greetings
Frank
_______________________________________________
p2-dev mailing list
p2-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/p2-dev